netdev - [PATCH net-next v2] net/9p/trans_fd: check the return value of parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 13:23:21 -0700
From:   Li Zhong <floridsleeves@...il.com>
To:     netdev@...r.kernel.org, v9fs-developer@...ts.sourceforge.net
Cc:     pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
        davem@...emloft.net, linux_oss@...debyte.com,
        asmadeus@...ewreck.org, lucho@...kov.net, ericvh@...il.com,
        Li Zhong <floridsleeves@...il.com>
Subject: [PATCH net-next v2] net/9p/trans_fd: check the return value of parse_opts

parse_opts() could fail when there is error parsing mount options into
p9_fd_opts structure due to allocation failure. In that case opts will
contain invalid data. Though the value check on opts will prevent
invalid data from being used, we still add the check and return the
error code to avoid confusions for developers.

Signed-off-by: Li Zhong <floridsleeves@...il.com>
---
 net/9p/trans_fd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index e758978b44be..11ae64c1a24b 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -1061,7 +1061,9 @@ p9_fd_create(struct p9_client *client, const char *addr, char *args)
 	int err;
 	struct p9_fd_opts opts;
 
-	parse_opts(args, &opts);
+	err = parse_opts(args, &opts);
+	if (err < 0)
+		return err;
 	client->trans_opts.fd.rfd = opts.rfd;
 	client->trans_opts.fd.wfd = opts.wfd;
 
-- 
2.25.1