netdev - Re: [PATCH iproute2] taprio: support dumping and setting per-tc max SDU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12ecc390-bd02-9e06-ac29-416e79462064@kernel.org>
Date:   Thu, 22 Sep 2022 16:29:43 -0700
From:   David Ahern <dsahern@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2] taprio: support dumping and setting per-tc max
 SDU

On 9/14/22 2:07 PM, Vladimir Oltean wrote:
> The 802.1Q queueMaxSDU table is technically implemented in Linux as
> the TCA_TAPRIO_TC_ENTRY_MAX_SDU attribute of the TCA_TAPRIO_ATTR_TC_ENTRY
> nest. Multiple TCA_TAPRIO_ATTR_TC_ENTRY nests may appear in the netlink
> message, one per traffic class. Other configuration items that are per
> traffic class are also supposed to go there.
> 
> This is done for future extensibility of the netlink interface (I have
> the feeling that the struct tc_mqprio_qopt passed through
> TCA_TAPRIO_ATTR_PRIOMAP is not exactly extensible, which kind of defeats
> the purpose of using netlink). But otherwise, the max-sdu is parsed from
> the user, and printed, just like any other fixed-size 16 element array.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> This is the user space counterpart of:
> https://patchwork.kernel.org/project/netdevbpf/cover/20220914153303.1792444-1-vladimir.oltean@nxp.com/
> 

still waiting for the upstream api to be merged. When that happens,
repost and include example command lines for setting and dumping along
with json output to the cover letter. Also, include tc folks such as
Jamal, Jiri and Cong