lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Sep 2022 17:29:52 -0700 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Yonghong Song <yhs@...com> Cc: Tao Chen <chentao.kernel@...ux.alibaba.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] libbpf: Support raw btf placed in the default path On Mon, Sep 19, 2022 at 8:40 PM Yonghong Song <yhs@...com> wrote: > > > > On 9/12/22 9:43 AM, Tao Chen wrote: > > Now only elf btf can be placed in the default path(/boot), raw > > btf should also can be there. > > There are more default paths than just /boot. Also some grammer > issues in the above like 'should also can be'. > > Maybe the commit message can be changed like below. > > Currently, the default vmlinux files at '/boot/vmlinux-*', > '/lib/modules/*/vmlinux-*' etc. are parsed with 'btf__parse_elf' > to extract BTF. It is possible that these files are actually > raw BTF files similar to /sys/kernel/btf/vmlinux. So parse > these files with 'btf__parse' which tries both raw format and > ELF format. > Thanks, Yonghong, I used this description verbatim when applying. Also added a sentence on why users might use this instead of providing the btf_custom_path option. > It would be great if you can add more information on why > '/boot/vmlinux-*' or '/lib/modules/*/vmlinux-*' might be > a raw BTF file in your system. > > > > > Signed-off-by: Tao Chen <chentao.kernel@...ux.alibaba.com> > > Ack with some commit message changes in the above. > > Acked-by: Yonghong Song <yhs@...com>
Powered by blists - more mailing lists