netdev - Re: [PATCH] flow_dissector: Do not count vlan tags inside tunnel payload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 02:00:17 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Qingqing Yang <qingqing.yang@...adcom.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, boris.sukholitko@...adcom.com,
        kurt@...utronix.de, f.fainelli@...il.com, paulb@...dia.com,
        wojciech.drewek@...el.com, komachi.yoshiki@...il.com,
        ludovic.cintrat@...ewatcher.com
Subject: Re: [PATCH] flow_dissector: Do not count vlan tags inside tunnel payload

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 19 Sep 2022 15:48:08 +0800 you wrote:
> We've met the problem that when there is a vlan tag inside
> GRE encapsulation, the match of num_of_vlans fails.
> It is caused by the vlan tag inside GRE payload has been
> counted into num_of_vlans, which is not expected.
> 
> One example packet is like this:
> Ethernet II, Src: Broadcom_68:56:07 (00:10:18:68:56:07)
>                    Dst: Broadcom_68:56:08 (00:10:18:68:56:08)
> 802.1Q Virtual LAN, PRI: 0, DEI: 0, ID: 100
> Internet Protocol Version 4, Src: 192.168.1.4, Dst: 192.168.1.200
> Generic Routing Encapsulation (Transparent Ethernet bridging)
> Ethernet II, Src: Broadcom_68:58:07 (00:10:18:68:58:07)
>                    Dst: Broadcom_68:58:08 (00:10:18:68:58:08)
> 802.1Q Virtual LAN, PRI: 0, DEI: 0, ID: 200
> ...
> It should match the (num_of_vlans 1) rule, but it matches
> the (num_of_vlans 2) rule.
> 
> [...]

Here is the summary with links:
  - flow_dissector: Do not count vlan tags inside tunnel payload
    https://git.kernel.org/netdev/net-next/c/9f87eb424699

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html