lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8007b455dd18837c06ab099a6009505e7dddc124.camel@mediatek.com> Date: Fri, 23 Sep 2022 09:48:28 +0800 From: Jianguo Zhang <jianguo.zhang@...iatek.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "David S . Miller" <davem@...emloft.net>, Rob Herring <robh+dt@...nel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> CC: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, "Matthias Brugger" <matthias.bgg@...il.com>, Biao Huang <biao.huang@...iatek.com>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, Christophe Roullier <christophe.roullier@...com> Subject: Re: [resend PATCH v4 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Dear Krzysztof, Thanks for your comment. On Thu, 2022-09-22 at 17:07 +0200, Krzysztof Kozlowski wrote: > On 22/09/2022 11:27, Jianguo Zhang wrote: > > The clk_csr property is parsed in driver for generating MDC clock > > with correct frequency. A warning('clk_csr' was unexpeted) is > > reported > > when runing 'make_dtbs_check' because the clk_csr property > > has been not documented in the binding file. > > > > You did not describe the case, but apparently this came with > 81311c03ab4d ("net: ethernet: stmmac: add management of clk_csr > property") which never brought the bindings change. > > Therefore the property was never part of bindings documentation and > bringing them via driver is not the correct process. It bypasses the > review and such bypass cannot be an argument to bring the property to > bindings. It's not how new properties can be added. > > Therefore I don't agree. Please make it a property matching bindings, > so > vendor prefix, no underscores in node names. > > Driver and DTS need updates. > We will rename the property 'clk_csr' as 'snps,clk-csr' and update DTS & driver to align with the new name in next versions patches. > Best regards, > Krzysztof > BRS Jianguo
Powered by blists - more mailing lists