netdev - Re: [PATCH net-next 7/7] tsnep: Rework RX buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf75ebb5-c8ab-ed41-9256-57a55b2d18da@engleder-embedded.com>
Date:   Fri, 23 Sep 2022 21:33:40 +0200
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, robh+dt@...nel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 7/7] tsnep: Rework RX buffer allocation

On 22.09.22 03:01, Jakub Kicinski wrote:
> On Thu, 15 Sep 2022 22:36:37 +0200 Gerhard Engleder wrote:
>> Try to refill RX queue continously instead of dropping frames if
>> allocation fails. This seems to be the more common pattern for network
>> drivers and makes future XDP support simpler.
> 
> Is there anything preventing the queue from becoming completely empty
> and potentially never getting refilled?
> 
> The lazy refill usually comes with some form of a watchdog / periodic
> depletion check.

You are right, I need to improve that. I will remove that commit for
now and rework it.