netdev - Re: [PATCH net-next 4/6] sfc: add a hashtable for offloaded TC rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Sep 2022 07:10:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     ecree@...inx.com, netdev@...r.kernel.org, linux-net-drivers@....com
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, habetsm.xilinx@...il.com,
        Edward Cree <ecree.xilinx@...il.com>,
        Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
Subject: Re: [PATCH net-next 4/6] sfc: add a hashtable for offloaded TC rules

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/ecree-xilinx-com/sfc-bare-bones-TC-offload/20220924-053109
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4dfa5f05fffac3a8fa4f9a68a671b5b7e6d3b411
config: loongarch-allyesconfig
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/39e7779a9c4e14e48ed74ef853115fab0805fb62
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review ecree-xilinx-com/sfc-bare-bones-TC-offload/20220924-053109
        git checkout 39e7779a9c4e14e48ed74ef853115fab0805fb62
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/net/ethernet/sfc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/sfc/tc.c:23:17: warning: no previous prototype for 'efx_tc_flower_lookup_efv' [-Wmissing-prototypes]
      23 | struct efx_rep *efx_tc_flower_lookup_efv(struct efx_nic *efx,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/efx_tc_flower_lookup_efv +23 drivers/net/ethernet/sfc/tc.c

    17	
    18	#define EFX_EFV_PF	NULL
    19	/* Look up the representor information (efv) for a device.
    20	 * May return NULL for the PF (us), or an error pointer for a device that
    21	 * isn't supported as a TC offload endpoint
    22	 */
  > 23	struct efx_rep *efx_tc_flower_lookup_efv(struct efx_nic *efx,
    24						 struct net_device *dev)
    25	{
    26		struct efx_rep *efv;
    27	
    28		if (!dev)
    29			return ERR_PTR(-EOPNOTSUPP);
    30		/* Is it us (the PF)? */
    31		if (dev == efx->net_dev)
    32			return EFX_EFV_PF;
    33		/* Is it an efx vfrep at all? */
    34		if (dev->netdev_ops != &efx_ef100_rep_netdev_ops)
    35			return ERR_PTR(-EOPNOTSUPP);
    36		/* Is it ours?  We don't support TC rules that include another
    37		 * EF100's netdevices (not even on another port of the same NIC).
    38		 */
    39		efv = netdev_priv(dev);
    40		if (efv->parent != efx)
    41			return ERR_PTR(-EOPNOTSUPP);
    42		return efv;
    43	}
    44	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (323002 bytes)