lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220922194214.108f7701@kernel.org> Date: Thu, 22 Sep 2022 19:42:14 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Xiaoliang Yang <xiaoliang.yang_1@....com>, Claudiu Manoil <claudiu.manoil@....com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next 1/2] net: enetc: cache accesses to &priv->si->hw On Wed, 21 Sep 2022 17:43:48 +0300 Vladimir Oltean wrote: > The &priv->si->hw construct dereferences 2 pointers and makes lines > longer than they need to be, in turn making the code harder to read. > > Replace &priv->si->hw accesses with a "hw" variable when there are 2 or > more accesses within a function that dereference this. This includes > loops, since &priv->si->hw is a loop invariant. Could you resend? pw checker could not apply it, it must have depended on the fixes from net.
Powered by blists - more mailing lists