netdev - Re: [PATCH iproute2-next 1/1] ip: add NLM_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yy0y3qIS1rLGt3s1@Laptop-X1>
Date:   Fri, 23 Sep 2022 12:15:26 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        Guillaume Nault <gnault@...hat.com>
Subject: Re: [PATCH iproute2-next 1/1] ip: add NLM_F_ECHO support

On Thu, Sep 22, 2022 at 04:17:08PM -0700, David Ahern wrote:
> > +	if (echo_request)
> > +		req.n.nlmsg_flags |= NLM_F_ECHO|NLM_F_ACK;
> 
> fixed the spacing on the flags (all locations) and applied to iproute2-next.

Thanks for the fixing!
> >  
> > +	if (echo_request) {
> > +		new_json_obj(json);
> > +		open_json_object(NULL);
> > +		print_addrinfo(answer, stdout);
> > +		close_json_object();
> > +		delete_json_obj();
> > +		free(answer);
> > +	}
> 
> That list is redundant. I think it can be turned into a util function
> that takes an the print function as an input argument.

I will post a patch to remove the redundant code.

Hangbin