lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yy7xzZ/AhIn+VxYo@kroah.com> Date: Sat, 24 Sep 2022 14:02:21 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Sasha Levin <sashal@...nel.org> Cc: Marcin Wojtas <mw@...ihalf.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, stable@...nel.org Subject: Re: [PATCH] Revert "net: mvpp2: debugfs: fix memory leak when using debugfs_lookup()" On Fri, Sep 23, 2022 at 07:47:36PM -0400, Sasha Levin wrote: > This reverts commit fe2c9c61f668cde28dac2b188028c5299cedcc1e. > > On Tue, Sep 13, 2022 at 05:48:58PM +0100, Russell King (Oracle) wrote: > >What happens if this is built as a module, and the module is loaded, > >binds (and creates the directory), then is removed, and then re- > >inserted? Nothing removes the old directory, so doesn't > >debugfs_create_dir() fail, resulting in subsequent failure to add > >any subsequent debugfs entries? > > > >I don't think this patch should be backported to stable trees until > >this point is addressed. > > Revert until a proper fix is available as the original behavior was > better. > > Cc: Marcin Wojtas <mw@...ihalf.com> > Cc: Russell King <linux@...linux.org.uk> > Cc: "David S. Miller" <davem@...emloft.net> > Cc: Eric Dumazet <edumazet@...gle.com> > Cc: Jakub Kicinski <kuba@...nel.org> > Cc: Paolo Abeni <pabeni@...hat.com> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: netdev@...r.kernel.org > Cc: stable@...nel.org > Reported-by: Russell King <linux@...linux.org.uk> > Fixes: fe2c9c61f668 ("net: mvpp2: debugfs: fix memory leak when using debugfs_lookup()") > Signed-off-by: Sasha Levin <sashal@...nel.org> > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists