lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yy8ZXFoWYIE0qpWp@dev-arch.thelio-3990X> Date: Sat, 24 Sep 2022 07:51:08 -0700 From: Nathan Chancellor <nathan@...nel.org> To: Lorenzo Bianconi <lorenzo@...nel.org> Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com, pablo@...filter.org, fw@...len.de, netfilter-devel@...r.kernel.org, lorenzo.bianconi@...hat.com, brouer@...hat.com, toke@...hat.com, memxor@...il.com Subject: Re: [PATCH v3 bpf-next 2/3] net: netfilter: add bpf_ct_set_nat_info kfunc helper On Sat, Sep 24, 2022 at 01:10:44PM +0200, Lorenzo Bianconi wrote: > > > Hi Lorenzo, > > > > Hi Nathan, > > > > > > > > On Wed, Sep 21, 2022 at 06:48:26PM +0200, Lorenzo Bianconi wrote: > > > > Introduce bpf_ct_set_nat_info kfunc helper in order to set source and > > > > destination nat addresses/ports in a new allocated ct entry not inserted > > > > in the connection tracking table yet. > > > > > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org> > > > > > > This commit is now in -next as commit 0fabd2aa199f ("net: netfilter: add > > > bpf_ct_set_nat_info kfunc helper"). Unfortunately, it introduces a > > > circular dependency when I build with my distribution's (Arch Linux) > > > configuration: > > > > > > $ curl -LSso .config https://github.com/archlinux/svntogit-packages/raw/packages/linux/trunk/config > > > > > > $ make -skj"$(nproc)" INSTALL_MOD_PATH=rootfs INSTALL_MOD_STRIP=1 olddefconfig all modules_install > > > ... > > > WARN: multiple IDs found for 'nf_conn': 99333, 114119 - using 99333 > > > WARN: multiple IDs found for 'nf_conn': 99333, 115663 - using 99333 > > > WARN: multiple IDs found for 'nf_conn': 99333, 117330 - using 99333 > > > WARN: multiple IDs found for 'nf_conn': 99333, 119583 - using 99333 > > > depmod: ERROR: Cycle detected: nf_conntrack -> nf_nat -> nf_conntrack > > > depmod: ERROR: Found 2 modules in dependency cycles! > > > > I guess the issue occurs when we compile both nf_conntrack and nf_nat as module > > since now we introduced the dependency "nf_conntrack -> nf_nat". > > Discussing with Kumar, in order to fix it, we can move bpf_ct_set_nat_info() in > > nf_nat module (with some required registration code similar to register_nf_conntrack_bpf()). > > What do you think? > > Sorry for the inconvenience. > > Hi Nathan, > > this is a PoC of what I described above: > https://github.com/LorenzoBianconi/bpf-next/commit/765d32dd08e56f5059532845e70d0bbfe4badda1 Thanks, that appears to resolve the error for me! Tested-by: Nathan Chancellor <nathan@...nel.org> > Regards, > Lorenzo > > > > > Regards, > > Lorenzo > > > > > > > ... > > > > > > The WARN lines are there before this change but I figured they were > > > worth including anyways, in case they factor in here. > > > > > > If there is any more information I can provide or patches I can test, > > > please let me know! > > > > > > Cheers, > > > Nathan > >
Powered by blists - more mailing lists