lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM0EoMm9uBQQepMb5bda1vR-Okw-tPp2nnf6TvfA0FzPu_D_2A@mail.gmail.com> Date: Sun, 25 Sep 2022 12:14:44 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: syzbot <syzbot+a2c4601efc75848ba321@...kaller.appspotmail.com> Cc: davem@...emloft.net, edumazet@...gle.com, jiri@...nulli.us, kuba@...nel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, pabeni@...hat.com, syzkaller-bugs@...glegroups.com, xiyou.wangcong@...il.com Subject: Re: [syzbot] WARNING in u32_change On Sun, Sep 25, 2022 at 11:38 AM Jamal Hadi Salim <jhs@...atatu.com> wrote: > > Is there a way to tell the boat "looking into it?" I guess I have to swim across to it to get the message;-> I couldnt see the warning message but it is obvious by inspection that the memcpy is broken. We should add more test coverage. This should fix it. Will send a formal patch later: diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 4d27300c2..591cbbf27 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -1019,7 +1019,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, } s = nla_data(tb[TCA_U32_SEL]); - sel_size = struct_size(s, keys, s->nkeys); + sel_size = struct_size(s, keys, s->nkeys) + sizeof(n->sel); if (nla_len(tb[TCA_U32_SEL]) < sel_size) { err = -EINVAL; goto erridr;
Powered by blists - more mailing lists