netdev - Re: [PATCH 1/2] net: ethernet: mtk_eth_soc: fix wrong use of new helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzDF6n2VX4qwX/I6@lore-desk>
Date:   Sun, 25 Sep 2022 23:19:38 +0200
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Daniel Golle <daniel@...rotopia.org>
Cc:     linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
        Sujuan Chen <sujuan.chen@...iatek.com>,
        Bo Jiao <Bo.Jiao@...iatek.com>, Felix Fietkau <nbd@....name>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chen Minqiang <ptpt52@...il.com>
Subject: Re: [PATCH 1/2] net: ethernet: mtk_eth_soc: fix wrong use of new
 helper function

> In function mtk_foe_entry_set_vlan() the call to field accessor macro
> FIELD_GET(MTK_FOE_IB1_BIND_VLAN_LAYER, entry->ib1)
> has been wrongly replaced by
> mtk_prep_ib1_vlan_layer(eth, entry->ib1)
> 
> Use correct helper function mtk_get_ib1_vlan_layer instead.

Acked-by: Lorenzo Bianconi <lorenzo@...nel.org>

> 
> Reported-by: Chen Minqiang <ptpt52@...il.com>
> Fixes: 03a3180e5c09e1 ("net: ethernet: mtk_eth_soc: introduce flow offloading support for mt7986")
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.c b/drivers/net/ethernet/mediatek/mtk_ppe.c
> index 25f8738a062bd0..4ea2b342f252ac 100644
> --- a/drivers/net/ethernet/mediatek/mtk_ppe.c
> +++ b/drivers/net/ethernet/mediatek/mtk_ppe.c
> @@ -337,7 +337,7 @@ int mtk_foe_entry_set_vlan(struct mtk_eth *eth, struct mtk_foe_entry *entry,
>  {
>  	struct mtk_foe_mac_info *l2 = mtk_foe_entry_l2(eth, entry);
>  
> -	switch (mtk_prep_ib1_vlan_layer(eth, entry->ib1)) {
> +	switch (mtk_get_ib1_vlan_layer(eth, entry->ib1)) {
>  	case 0:
>  		entry->ib1 |= mtk_get_ib1_vlan_tag_mask(eth) |
>  			      mtk_prep_ib1_vlan_layer(eth, 1);
> -- 
> 2.37.3
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)