netdev - Re: [PATCH net-next] net/sched: taprio: simplify list iteration in taprio_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87illa80a0.fsf@intel.com>
Date:   Mon, 26 Sep 2022 11:21:11 -0700
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: taprio: simplify list iteration in
 taprio_dev_notifier()

Vladimir Oltean <vladimir.oltean@....com> writes:

> taprio_dev_notifier() subscribes to netdev state changes in order to
> determine whether interfaces which have a taprio root qdisc have changed
> their link speed, so the internal calculations can be adapted properly.
>
> The 'qdev' temporary variable serves no purpose, because we just use it
> only once, and can just as well use qdisc_dev(q->root) directly (or the
> "dev" that comes from the netdev notifier; this is because qdev is only
> interesting if it was the subject of the state change, _and_ its root
> qdisc belongs in the taprio list).
>
> The 'found' variable also doesn't really serve too much of a purpose
> either; we can just call taprio_set_picos_per_byte() within the loop,
> and exit immediately afterwards.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---

Thanks,

Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>


Cheers,
-- 
Vinicius