lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAL_JsqK7auA8coB3DCqSDKw1ept_yQihVs-Me3bvU923os23xg@mail.gmail.com> Date: Mon, 26 Sep 2022 13:25:05 -0500 From: Rob Herring <robh@...nel.org> To: Olof Johansson <olof@...om.net> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Saravana Kannan <saravanak@...gle.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Laurentiu Tudor <laurentiu.tudor@....com>, Jiri Slaby <jirislaby@...nel.org>, Michael Ellerman <mpe@...erman.id.au>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>, Nicolas Saenz Julienne <nsaenz@...nel.org>, Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Florian Fainelli <f.fainelli@...il.com>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Al Cooper <alcooperx@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Paul Cercueil <paul@...pouillou.net>, Vladimir Zapolskiy <vz@...ia.com>, Matthias Brugger <matthias.bgg@...il.com>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, Masami Hiramatsu <mhiramat@...nel.org>, Tobias Klauser <tklauser@...tanz.ch>, Russell King <linux@...linux.org.uk>, Vineet Gupta <vgupta@...nel.org>, Richard Genoud <richard.genoud@...il.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...rochip.com>, Alexander Shiyan <shc_work@...l.ru>, Baruch Siach <baruch@...s.co.il>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>, Karol Gugala <kgugala@...micro.com>, Mateusz Holenko <mholenko@...micro.com>, Gabriel Somlo <gsomlo@...il.com>, Neil Armstrong <narmstrong@...libre.com>, Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Taichi Sugaya <sugaya.taichi@...ionext.com>, Takao Orito <orito.takao@...ionext.com>, Liviu Dudau <liviu.dudau@....com>, Sudeep Holla <sudeep.holla@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Pali Rohar <pali@...nel.org>, Andreas Farber <afaerber@...e.de>, Manivannan Sadhasivam <mani@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Alim Akhtar <alim.akhtar@...sung.com>, Laxman Dewangan <ldewangan@...dia.com>, Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, Orson Zhai <orsonzhai@...il.com>, Baolin Wang <baolin.wang7@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>, Patrice Chotard <patrice.chotard@...s.st.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, "David S. Miller" <davem@...emloft.net>, Hammer Hsieh <hammerh0314@...il.com>, Peter Korsgaard <jacmet@...site.dk>, Timur Tabi <timur@...nel.org>, Michal Simek <michal.simek@...inx.com>, sascha hauer <sha@...gutronix.de>, peng fan <peng.fan@....com>, kevin hilman <khilman@...nel.org>, ulf hansson <ulf.hansson@...aro.org>, len brown <len.brown@...el.com>, pavel machek <pavel@....cz>, joerg roedel <joro@...tes.org>, will deacon <will@...nel.org>, andrew lunn <andrew@...n.ch>, heiner kallweit <hkallweit1@...il.com>, eric dumazet <edumazet@...gle.com>, jakub kicinski <kuba@...nel.org>, paolo abeni <pabeni@...hat.com>, linus walleij <linus.walleij@...aro.org>, hideaki yoshifuji <yoshfuji@...ux-ipv6.org>, david ahern <dsahern@...nel.org>, kernel-team@...roid.com, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, iommu@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-gpio@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-rpi-kernel@...ts.infradead.org, linux-mips@...r.kernel.org, linux-mediatek@...ts.infradead.org, linux-tegra@...r.kernel.org, linux-snps-arc@...ts.infradead.org, linux-amlogic@...ts.infradead.org, linux-arm-msm@...r.kernel.org, linux-actions@...ts.infradead.org, linux-unisoc@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-riscv@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com, sparclinux@...r.kernel.org Subject: Re: [PATCH v2 0/2] Fix console probe delay when stdout-path isn't set On Mon, Sep 19, 2022 at 5:56 PM Olof Johansson <olof@...om.net> wrote: > > On Mon, Sep 19, 2022 at 1:44 AM Greg Kroah-Hartman > <gregkh@...uxfoundation.org> wrote: > > > > On Sun, Sep 18, 2022 at 08:44:27PM -0700, Olof Johansson wrote: > > > On Tue, Aug 23, 2022 at 8:37 AM Greg Kroah-Hartman > > > <gregkh@...uxfoundation.org> wrote: > > > > > > > > On Thu, Jun 30, 2022 at 06:26:38PM -0700, Saravana Kannan wrote: > > > > > These patches are on top of driver-core-next. > > > > > > > > > > Even if stdout-path isn't set in DT, this patch should take console > > > > > probe times back to how they were before the deferred_probe_timeout > > > > > clean up series[1]. > > > > > > > > Now dropped from my queue due to lack of a response to other reviewer's > > > > questions. > > > > > > What happened to this patch? I have a 10 second timeout on console > > > probe on my SiFive Unmatched, and I don't see this flag being set for > > > the serial driver. In fact, I don't see it anywhere in-tree. I can't > > > seem to locate another patchset from Saravana around this though, so > > > I'm not sure where to look for a missing piece for the sifive serial > > > driver. > > > > > > This is the second boot time regression (this one not fatal, unlike > > > the Layerscape PCIe one) from the fw_devlink patchset. > > > > > > Greg, can you revert the whole set for 6.0, please? It's obviously > > > nowhere near tested enough to go in and I expect we'll see a bunch of > > > -stable fixups due to this if we let it remain in. > > > > What exactly is "the whole set"? I have the default option fix queued > > up and will send that to Linus later this week (am traveling back from > > Plumbers still), but have not heard any problems about any other issues > > at all other than your report. > > I stand corrected in this case, the issue on the Hifive Unmatched was > a regression due to a PWM clock change -- I just sent a patch for that > (serial driver fix). > > So it seems like as long as the fw_devlink.strict=1 patch is reverted, > things are back to a working state here. > > I still struggle with how the fw_devlink patchset is expected to work > though, since DT is expected to describe the hardware configuration, > and it has no knowledge of whether there are drivers that will be > bound to any referenced supplier devnodes. It's not going to work well > to assume that they will always be bound, and to add 10 second > timeouts for those cases isn't a good solution. Seems like the number > of special cases will keep adding up. Since the introduction of deferred probe, the kernel has always assumed if there is a device described, then there is or will be a driver for it. The result is you can't use new DTs (if they add providers) with older kernels. We've ended up with a timeout because no one has come up with a better way to handle it. What the kernel needs is userspace saying "I'm done loading modules", but it's debatable whether that's a good solution too. Rob
Powered by blists - more mailing lists