netdev - Re: [net-next PATCH 8/8] octeontx2-pf: mcs: Introduce MACSEC hardware offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220926130100.4f315759@kernel.org>
Date:   Mon, 26 Sep 2022 13:01:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Subbaraya Sundeep <sbhatta@...vell.com>
Cc:     <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <sgoutham@...vell.com>,
        <naveenm@...vell.com>
Subject: Re: [net-next PATCH 8/8] octeontx2-pf: mcs: Introduce MACSEC
 hardware offloading

On Mon, 26 Sep 2022 19:07:01 +0530 Subbaraya Sundeep wrote:
> This patch introduces the macsec offload feature to cn10k
> PF netdev driver. The macsec offload ops like adding, deleting
> and updating SecYs, SCs, SAs and stats are supported. XPN support
> will be added in later patches. Some stats use same counter in hardware
> which means based on the SecY mode the same counter represents different
> stat. Hence when SecY mode/policy is changed then snapshot of current
> stats are captured. Also there is no provision to specify the unique
> flow-id/SCI per packet to hardware hence different mac address needs to
> be set for macsec interfaces.

Does not build:

drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:1258:36: error: no member named 'macsec_cfg' in 'struct otx2_nic'
        struct cn10k_mcs_cfg *cfg = pfvf->macsec_cfg;
                                    ~~~~  ^

Please make sure you wait at least 24h before reposting.