lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <878rm64le2.fsf@kernel.org> Date: Mon, 26 Sep 2022 10:58:45 +0300 From: Kalle Valo <kvalo@...nel.org> To: Ruan Jinjie <ruanjinjie@...wei.com> Cc: Franky Lin <franky.lin@...adcom.com>, <aspriel@...il.com>, <hante.meuleman@...adcom.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <marcan@...can.st>, <linus.walleij@...aro.org>, <rmk+kernel@...linux.org.uk>, <soontak.lee@...ress.com>, <linux-wireless@...r.kernel.org>, <SHA-cyfmac-dev-list@...ineon.com>, <brcm80211-dev-list.pdl@...adcom.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH -next] wifi: brcmfmac: pcie: add missing pci_disable_device() in brcmf_pcie_get_resource() Ruan Jinjie <ruanjinjie@...wei.com> writes: > On 2022/9/24 0:50, Franky Lin wrote: >> On Fri, Sep 23, 2022 at 2:42 AM ruanjinjie <ruanjinjie@...wei.com> wrote: >>> >>> Add missing pci_disable_device() if brcmf_pcie_get_resource() fails. >> >> Did you encounter any issue because of the absensent >> pci_disable_device? A bit more context will be very helpful. >> > > We use static analysis via coccinelle to find the above issue. The > command we use is below: > > spatch -I include -timeout 60 -very_quiet -sp_file > pci_disable_device_missing.cocci > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c Please include this information to the commit log, it helps to understand the background of the fix. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists