netdev - Re: [RESEND net-next PATCH] net: rtnetlink: Enslave device before bringing it up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 13:13:58 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Phil Sutter <phil@....cc>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        dsahern@...il.com
Subject: Re: [RESEND net-next PATCH] net: rtnetlink: Enslave device before
 bringing it up

Wed, Sep 14, 2022 at 05:06:23PM CEST, phil@....cc wrote:
>Unlike with bridges, one can't add an interface to a bond and set it up
>at the same time:
>
>| # ip link set dummy0 down
>| # ip link set dummy0 master bond0 up
>| Error: Device can not be enslaved while up.
>
>Of all drivers with ndo_add_slave callback, bond and team decline if
>IFF_UP flag is set, vrf cycles the interface (i.e., sets it down and
>immediately up again) and the others just don't care.
>
>Support the common notion of setting the interface up after enslaving it
>by sorting the operations accordingly.
>
>Signed-off-by: Phil Sutter <phil@....cc>

Reviewed-by: Jiri Pirko <jiri@...dia.com>