lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YzLPZrNdm4Ol6hUb@unreal> Date: Tue, 27 Sep 2022 13:24:38 +0300 From: Leon Romanovsky <leon@...nel.org> To: Jakub Kicinski <kuba@...nel.org> Cc: "huangguangbin (A)" <huangguangbin2@...wei.com>, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, lipeng321@...wei.com, lanhao@...wei.com Subject: Re: [PATCH net-next 00/14] redefine some macros of feature abilities judgement On Mon, Sep 26, 2022 at 10:11:35AM -0700, Jakub Kicinski wrote: > On Mon, 26 Sep 2022 20:56:26 +0800 huangguangbin (A) wrote: > > On 2022/9/24 19:27, Leon Romanovsky wrote: > > > On Sat, Sep 24, 2022 at 10:30:10AM +0800, Guangbin Huang wrote: > > >> The macros hnae3_dev_XXX_supported just can be used in hclge layer, but > > >> hns3_enet layer may need to use, so this serial redefine these macros. > > > > > > IMHO, you shouldn't add new obfuscated code, but delete it. > > > > > > Jakub, > > > > > > The more drivers authors will obfuscate in-kernel primitives and reinvent > > > their own names, macros e.t.c, the less external reviewers you will be able > > > to attract. > > > > > > IMHO, netdev should have more active position do not allow obfuscated code. > > > > > > Thanks > > > > > > > Hi, Leon > > I'm sorry, I can not get your point. Can you explain in more detail? > > Do you mean the name "macro" should not be used? > > He is saying that you should try to remove those macros rather than > touch them up. Exactly, thanks Jakub.
Powered by blists - more mailing lists