netdev - Re: [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b50703c-9de0-3331-0517-2691b7005489@gmail.com>
Date:   Tue, 27 Sep 2022 10:23:23 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     Jon Hunter <jonathanh@...dia.com>,
        Bhadram Varka <vbhadram@...dia.com>,
        linux-tegra@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support

+Russell, Andrew, Vladimir,

On 9/23/22 04:49, Thierry Reding wrote:
> From: Bhadram Varka <vbhadram@...dia.com>
> 
> Add support for the Multi-Gigabit Ethernet (MGBE/XPCS) IP found on
> NVIDIA Tegra234 SoCs.
> 
> Signed-off-by: Bhadram Varka <vbhadram@...dia.com>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>   drivers/net/ethernet/stmicro/stmmac/Kconfig   |   6 +
>   drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
>   .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 290 ++++++++++++++++++

You should be modeling this as a proper PCS driver and have a 
'pcs-handle' property pointing to it in your Device Tree.

The configuration you are doing here is probably working the first time 
you bring-up the network device but I doubt it works across system 
suspend/resume states where power to the GMAC and PCS is lost, it also 
begs the question of which mediums this was tested with and whether 
dynamic switching of speeds and so on is working?
--
Florian