netdev - Re: [PATCH net-next] xdp: Adjust xdp_frame layout to avoid using bitfields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166423801357.11940.13487466744913747650.git-patchwork-notify@kernel.org>
Date:   Tue, 27 Sep 2022 00:20:13 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, john.fastabend@...il.com,
        davem@...emloft.net, ast@...nel.org, hawk@...nel.org,
        daniel@...earbox.net, edumazet@...gle.com, pabeni@...hat.com,
        bpf@...r.kernel.org, lorenzo@...nel.org
Subject: Re: [PATCH net-next] xdp: Adjust xdp_frame layout to avoid using
 bitfields

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 23 Sep 2022 14:48:00 +0200 you wrote:
> Practical experience (and advice from Alexei) tell us that bitfields in
> structs lead to un-optimized assemply code. I've verified this change
> does lead to better x86_64 assemply, both via objdump and playing with
> code snippets in godbolt.org.
> 
> Using scripts/bloat-o-meter shows the code size is reduced with 24
> bytes for xdp_convert_buff_to_frame() that gets inlined e.g. in
> i40e_xmit_xdp_tx_ring() which were used for microbenchmarking.
> 
> [...]

Here is the summary with links:
  - [net-next] xdp: Adjust xdp_frame layout to avoid using bitfields
    https://git.kernel.org/netdev/net-next/c/b860a1b964be

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html