netdev - RE: [PATCH -next] net: wwan: iosm: Use skb_put_data() instead of skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB4995FFF775B81E5CD94C658BD7559@CO1PR11MB4995.namprd11.prod.outlook.com>
Date:   Tue, 27 Sep 2022 06:41:04 +0000
From:   "Kumar, M Chetan" <m.chetan.kumar@...el.com>
To:     Shang XiaoJing <shangxiaojing@...wei.com>,
        linuxwwan <linuxwwan@...el.com>,
        "loic.poulain@...aro.org" <loic.poulain@...aro.org>,
        "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH -next] net: wwan: iosm: Use skb_put_data() instead of
 skb_put/memcpy pair

> -----Original Message-----
> From: Shang XiaoJing <shangxiaojing@...wei.com>
> Sent: Tuesday, September 27, 2022 8:03 AM
> To: Kumar, M Chetan <m.chetan.kumar@...el.com>; linuxwwan
> <linuxwwan@...el.com>; loic.poulain@...aro.org; ryazanov.s.a@...il.com;
> johannes@...solutions.net; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> netdev@...r.kernel.org
> Cc: shangxiaojing@...wei.com
> Subject: [PATCH -next] net: wwan: iosm: Use skb_put_data() instead of
> skb_put/memcpy pair
> 
> Use skb_put_data() instead of skb_put() and memcpy(), which is clear.
> 
> Signed-off-by: Shang XiaoJing <shangxiaojing@...wei.com>
> ---
>  drivers/net/wwan/iosm/iosm_ipc_imem_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c
> b/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c
> index 57304a5adf68..b7f9237dedf7 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c
> +++ b/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c
> @@ -590,7 +590,7 @@ int ipc_imem_sys_devlink_write(struct iosm_devlink
> *ipc_devlink,
>  		goto out;
>  	}
> 
> -	memcpy(skb_put(skb, count), buf, count);
> +	skb_put_data(skb, buf, count);
> 
>  	IPC_CB(skb)->op_type = UL_USR_OP_BLOCKED;

Reviewed-by: M Chetan Kumar <m.chetan.kumar@...el.com>