netdev - Re: [PATCH net v2] xfrm: Reinject transport-mode packets through workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220927075320.GR2950045@gauss3.secunet.de>
Date:   Tue, 27 Sep 2022 09:53:20 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Liu Jian <liujian56@...wei.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2] xfrm: Reinject transport-mode packets through
 workqueue

On Sat, Sep 24, 2022 at 04:01:57PM +0800, Liu Jian wrote:
> The following warning is displayed when the tcp6-multi-diffip11 stress
> test case of the LTP test suite is tested:
> 
> watchdog: BUG: soft lockup - CPU#0 stuck for 22s! [ns-tcpserver:48198]
> CPU: 0 PID: 48198 Comm: ns-tcpserver Kdump: loaded Not tainted 6.0.0-rc6+ #39
> Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015
> pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> pc : des3_ede_encrypt+0x27c/0x460 [libdes]
> lr : 0x3f
> sp : ffff80000ceaa1b0
> x29: ffff80000ceaa1b0 x28: ffff0000df056100 x27: ffff0000e51e5280
> x26: ffff80004df75030 x25: ffff0000e51e4600 x24: 000000000000003b
> x23: 0000000000802080 x22: 000000000000003d x21: 0000000000000038
> x20: 0000000080000020 x19: 000000000000000a x18: 0000000000000033
> x17: ffff0000e51e4780 x16: ffff80004e2d1448 x15: ffff80004e2d1248
> x14: ffff0000e51e4680 x13: ffff80004e2d1348 x12: ffff80004e2d1548
> x11: ffff80004e2d1848 x10: ffff80004e2d1648 x9 : ffff80004e2d1748
> x8 : ffff80004e2d1948 x7 : 000000000bcaf83d x6 : 000000000000001b
> x5 : ffff80004e2d1048 x4 : 00000000761bf3bf x3 : 000000007f1dd0a3
> x2 : ffff0000e51e4780 x1 : ffff0000e3b9a2f8 x0 : 00000000db44e872
> Call trace:
>  des3_ede_encrypt+0x27c/0x460 [libdes]
>  crypto_des3_ede_encrypt+0x1c/0x30 [des_generic]
>  crypto_cbc_encrypt+0x148/0x190
>  crypto_skcipher_encrypt+0x2c/0x40
>  crypto_authenc_encrypt+0xc8/0xfc [authenc]
>  crypto_aead_encrypt+0x2c/0x40
>  echainiv_encrypt+0x144/0x1a0 [echainiv]
>  crypto_aead_encrypt+0x2c/0x40
>  esp6_output_tail+0x1c8/0x5d0 [esp6]
>  esp6_output+0x120/0x278 [esp6]
>  xfrm_output_one+0x458/0x4ec
>  xfrm_output_resume+0x6c/0x1f0
>  xfrm_output+0xac/0x4ac
>  __xfrm6_output+0x130/0x270
>  xfrm6_output+0x60/0xec
>  ip6_xmit+0x2ec/0x5bc
>  inet6_csk_xmit+0xbc/0x10c
>  __tcp_transmit_skb+0x460/0x8c0
>  tcp_write_xmit+0x348/0x890
>  __tcp_push_pending_frames+0x44/0x110
>  tcp_rcv_established+0x3c8/0x720
>  tcp_v6_do_rcv+0xdc/0x4a0
>  tcp_v6_rcv+0xc24/0xcb0
>  ip6_protocol_deliver_rcu+0xf0/0x574
>  ip6_input_finish+0x48/0x7c
>  ip6_input+0x48/0xc0
>  ip6_rcv_finish+0x80/0x9c
>  xfrm_trans_reinject+0xb0/0xf4
>  tasklet_action_common.constprop.0+0xf8/0x134
>  tasklet_action+0x30/0x3c
>  __do_softirq+0x128/0x368
>  do_softirq+0xb4/0xc0

...

> The tasklet software interrupt takes too much time.

Do you know why this tasklet takes so long? Whatever happens in that
tasklet, it should not need more than 22s.

> Therefore, the
> xfrm_trans_reinject executor is changed from tasklet to workqueue.

Why should do a workqueue with BHs off better than a tasklet?