lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 27 Sep 2022 16:04:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Abhishek Pandit-Subedi <abhishekpandit@...gle.com>,
        linux-bluetooth@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Call shutdown for HCI_USER_CHANNEL

Hi Abhishek,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on bluetooth/master net-next/master net/master linus/master v6.0-rc7 next-20220923]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Abhishek-Pandit-Subedi/Bluetooth-Call-shutdown-for-HCI_USER_CHANNEL/20220927-120257
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: parisc-allyesconfig
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0c60eab323f044b8bc6ab401d691e1d47c117bbd
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Abhishek-Pandit-Subedi/Bluetooth-Call-shutdown-for-HCI_USER_CHANNEL/20220927-120257
        git checkout 0c60eab323f044b8bc6ab401d691e1d47c117bbd
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/bluetooth/hci_sync.c: In function 'hci_dev_close_sync':
>> net/bluetooth/hci_sync.c:4821:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
    4821 |         if (!was_userchannel)
         |         ^~
   net/bluetooth/hci_sync.c:4823:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    4823 |                 msft_do_close(hdev);
         |                 ^~~~~~~~~~~~~
   net/bluetooth/hci_sync.c: At top level:
   net/bluetooth/hci_sync.c:4826:9: error: expected identifier or '(' before 'if'
    4826 |         if (hdev->flush)
         |         ^~
   net/bluetooth/hci_sync.c:4830:25: error: expected declaration specifiers or '...' before '&' token
    4830 |         skb_queue_purge(&hdev->cmd_q);
         |                         ^
   net/bluetooth/hci_sync.c:4831:20: error: expected declaration specifiers or '...' before '&' token
    4831 |         atomic_set(&hdev->cmd_cnt, 1);
         |                    ^
   net/bluetooth/hci_sync.c:4831:36: error: expected declaration specifiers or '...' before numeric constant
    4831 |         atomic_set(&hdev->cmd_cnt, 1);
         |                                    ^
   net/bluetooth/hci_sync.c:4832:9: error: expected identifier or '(' before 'if'
    4832 |         if (test_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks) &&
         |         ^~
   net/bluetooth/hci_sync.c:4840:20: error: expected declaration specifiers or '...' before '&' token
    4840 |         flush_work(&hdev->cmd_work);
         |                    ^
   net/bluetooth/hci_sync.c:4843:25: error: expected declaration specifiers or '...' before '&' token
    4843 |         skb_queue_purge(&hdev->rx_q);
         |                         ^
   net/bluetooth/hci_sync.c:4844:25: error: expected declaration specifiers or '...' before '&' token
    4844 |         skb_queue_purge(&hdev->cmd_q);
         |                         ^
   net/bluetooth/hci_sync.c:4845:25: error: expected declaration specifiers or '...' before '&' token
    4845 |         skb_queue_purge(&hdev->raw_q);
         |                         ^
   net/bluetooth/hci_sync.c:4848:9: error: expected identifier or '(' before 'if'
    4848 |         if (hdev->sent_cmd) {
         |         ^~
   net/bluetooth/hci_sync.c:4854:31: error: expected ')' before '&' token
    4854 |         clear_bit(HCI_RUNNING, &hdev->flags);
         |                               ^~
         |                               )
   net/bluetooth/hci_sync.c:4855:33: error: expected ')' before numeric constant
    4855 |         hci_sock_dev_event(hdev, HCI_DEV_CLOSE);
         |                                 ^
         |                                 )
   net/bluetooth/hci_sync.c:4858:13: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
    4858 |         hdev->close(hdev);
         |             ^~
   net/bluetooth/hci_sync.c:4861:13: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
    4861 |         hdev->flags &= BIT(HCI_RAW);
         |             ^~
   In file included from net/bluetooth/hci_sync.c:11:
   include/net/bluetooth/hci_core.h:827:9: error: expected identifier or '(' before 'do'
     827 |         do {                                                    \
         |         ^~
   net/bluetooth/hci_sync.c:4862:9: note: in expansion of macro 'hci_dev_clear_volatile_flags'
    4862 |         hci_dev_clear_volatile_flags(hdev);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/net/bluetooth/hci_core.h:833:11: error: expected identifier or '(' before 'while'
     833 |         } while (0)
         |           ^~~~~
   net/bluetooth/hci_sync.c:4862:9: note: in expansion of macro 'hci_dev_clear_volatile_flags'
    4862 |         hci_dev_clear_volatile_flags(hdev);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/bluetooth/hci_sync.c:4865:13: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
    4865 |         hdev->amp_status = AMP_STATUS_POWERED_DOWN;
         |             ^~
   net/bluetooth/hci_sync.c:4867:20: error: expected ')' before '->' token
    4867 |         memset(hdev->eir, 0, sizeof(hdev->eir));
         |                    ^~
         |                    )
   net/bluetooth/hci_sync.c:4868:20: error: expected ')' before '->' token
    4868 |         memset(hdev->dev_class, 0, sizeof(hdev->dev_class));
         |                    ^~
         |                    )
   net/bluetooth/hci_sync.c:4869:15: error: expected declaration specifiers or '...' before '&' token
    4869 |         bacpy(&hdev->random_addr, BDADDR_ANY);
         |               ^
   In file included from net/bluetooth/hci_sync.c:10:
   include/net/bluetooth/bluetooth.h:341:21: error: expected declaration specifiers or '...' before '(' token
     341 | #define BDADDR_ANY  (&(bdaddr_t) {{0, 0, 0, 0, 0, 0}})
         |                     ^
   net/bluetooth/hci_sync.c:4869:35: note: in expansion of macro 'BDADDR_ANY'
    4869 |         bacpy(&hdev->random_addr, BDADDR_ANY);
         |                                   ^~~~~~~~~~
   net/bluetooth/hci_sync.c:4871:9: error: expected identifier or '(' before 'if'
    4871 |         if (was_userchannel)
         |         ^~
>> net/bluetooth/hci_sync.c:4874:9: warning: data definition has no type or storage class
    4874 |         hci_dev_put(hdev);
         |         ^~~~~~~~~~~
   net/bluetooth/hci_sync.c:4874:9: error: type defaults to 'int' in declaration of 'hci_dev_put' [-Werror=implicit-int]
>> net/bluetooth/hci_sync.c:4874:9: warning: parameter names (without types) in function declaration
   net/bluetooth/hci_sync.c:4874:9: error: conflicting types for 'hci_dev_put'; have 'int()'
   include/net/bluetooth/hci_core.h:1422:20: note: previous definition of 'hci_dev_put' with type 'void(struct hci_dev *)'
    1422 | static inline void hci_dev_put(struct hci_dev *d)
         |                    ^~~~~~~~~~~
   net/bluetooth/hci_sync.c:4875:9: error: expected identifier or '(' before 'return'
    4875 |         return err;
         |         ^~~~~~
   net/bluetooth/hci_sync.c:4876:1: error: expected identifier or '(' before '}' token
    4876 | }
         | ^
   net/bluetooth/hci_sync.c: In function 'hci_dev_close_sync':
   net/bluetooth/hci_sync.c:4824:9: error: control reaches end of non-void function [-Werror=return-type]
    4824 |         }
         |         ^
   cc1: some warnings being treated as errors


vim +/if +4821 net/bluetooth/hci_sync.c

  4729	
  4730	int hci_dev_close_sync(struct hci_dev *hdev)
  4731	{
  4732		bool auto_off;
  4733		int err = 0;
  4734		bool was_userchannel;
  4735	
  4736		bt_dev_dbg(hdev, "");
  4737	
  4738		/* Similar to how we first do setup and then set the exclusive access
  4739		 * bit for userspace, we must first unset userchannel and then clean up.
  4740		 * Otherwise, the kernel can't properly use the hci channel to clean up
  4741		 * the controller (some shutdown routines require sending additional
  4742		 * commands to the controller for example).
  4743		 */
  4744		was_userchannel = hci_dev_test_and_clear_flag(hdev, HCI_USER_CHANNEL);
  4745	
  4746		cancel_delayed_work(&hdev->power_off);
  4747		cancel_delayed_work(&hdev->ncmd_timer);
  4748		cancel_delayed_work(&hdev->le_scan_disable);
  4749		cancel_delayed_work(&hdev->le_scan_restart);
  4750	
  4751		hci_request_cancel_all(hdev);
  4752	
  4753		if (hdev->adv_instance_timeout) {
  4754			cancel_delayed_work_sync(&hdev->adv_instance_expire);
  4755			hdev->adv_instance_timeout = 0;
  4756		}
  4757	
  4758		if (!hci_dev_test_flag(hdev, HCI_UNREGISTER) &&
  4759		    test_bit(HCI_UP, &hdev->flags)) {
  4760			/* Execute vendor specific shutdown routine */
  4761			if (hdev->shutdown)
  4762				err = hdev->shutdown(hdev);
  4763		}
  4764	
  4765		if (!test_and_clear_bit(HCI_UP, &hdev->flags)) {
  4766			cancel_delayed_work_sync(&hdev->cmd_timer);
  4767			if (was_userchannel)
  4768				hci_dev_set_flag(hdev, HCI_USER_CHANNEL);
  4769			return err;
  4770		}
  4771	
  4772		hci_leds_update_powered(hdev, false);
  4773	
  4774		/* Flush RX and TX works */
  4775		flush_work(&hdev->tx_work);
  4776		flush_work(&hdev->rx_work);
  4777	
  4778		if (hdev->discov_timeout > 0) {
  4779			hdev->discov_timeout = 0;
  4780			hci_dev_clear_flag(hdev, HCI_DISCOVERABLE);
  4781			hci_dev_clear_flag(hdev, HCI_LIMITED_DISCOVERABLE);
  4782		}
  4783	
  4784		if (hci_dev_test_and_clear_flag(hdev, HCI_SERVICE_CACHE))
  4785			cancel_delayed_work(&hdev->service_cache);
  4786	
  4787		if (hci_dev_test_flag(hdev, HCI_MGMT)) {
  4788			struct adv_info *adv_instance;
  4789	
  4790			cancel_delayed_work_sync(&hdev->rpa_expired);
  4791	
  4792			list_for_each_entry(adv_instance, &hdev->adv_instances, list)
  4793				cancel_delayed_work_sync(&adv_instance->rpa_expired_cb);
  4794		}
  4795	
  4796		/* Avoid potential lockdep warnings from the *_flush() calls by
  4797		 * ensuring the workqueue is empty up front.
  4798		 */
  4799		drain_workqueue(hdev->workqueue);
  4800	
  4801		hci_dev_lock(hdev);
  4802	
  4803		hci_discovery_set_state(hdev, DISCOVERY_STOPPED);
  4804	
  4805		auto_off = hci_dev_test_and_clear_flag(hdev, HCI_AUTO_OFF);
  4806	
  4807		if (!auto_off && hdev->dev_type == HCI_PRIMARY &&
  4808		    !was_userchannel &&
  4809		    hci_dev_test_flag(hdev, HCI_MGMT))
  4810			__mgmt_power_off(hdev);
  4811	
  4812		hci_inquiry_cache_flush(hdev);
  4813		hci_pend_le_actions_clear(hdev);
  4814		hci_conn_hash_flush(hdev);
  4815		/* Prevent data races on hdev->smp_data or hdev->smp_bredr_data */
  4816		smp_unregister(hdev);
  4817		hci_dev_unlock(hdev);
  4818	
  4819		hci_sock_dev_event(hdev, HCI_DEV_DOWN);
  4820	
> 4821		if (!was_userchannel)
  4822			aosp_do_close(hdev);
  4823			msft_do_close(hdev);
  4824		}
  4825	
  4826		if (hdev->flush)
  4827			hdev->flush(hdev);
  4828	
  4829		/* Reset device */
  4830		skb_queue_purge(&hdev->cmd_q);
  4831		atomic_set(&hdev->cmd_cnt, 1);
  4832		if (test_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks) &&
  4833		    !auto_off && !hci_dev_test_flag(hdev, HCI_UNCONFIGURED)) {
  4834			set_bit(HCI_INIT, &hdev->flags);
  4835			hci_reset_sync(hdev);
  4836			clear_bit(HCI_INIT, &hdev->flags);
  4837		}
  4838	
  4839		/* flush cmd  work */
  4840		flush_work(&hdev->cmd_work);
  4841	
  4842		/* Drop queues */
  4843		skb_queue_purge(&hdev->rx_q);
  4844		skb_queue_purge(&hdev->cmd_q);
  4845		skb_queue_purge(&hdev->raw_q);
  4846	
  4847		/* Drop last sent command */
  4848		if (hdev->sent_cmd) {
  4849			cancel_delayed_work_sync(&hdev->cmd_timer);
  4850			kfree_skb(hdev->sent_cmd);
  4851			hdev->sent_cmd = NULL;
  4852		}
  4853	
  4854		clear_bit(HCI_RUNNING, &hdev->flags);
  4855		hci_sock_dev_event(hdev, HCI_DEV_CLOSE);
  4856	
  4857		/* After this point our queues are empty and no tasks are scheduled. */
  4858		hdev->close(hdev);
  4859	
  4860		/* Clear flags */
  4861		hdev->flags &= BIT(HCI_RAW);
  4862		hci_dev_clear_volatile_flags(hdev);
  4863	
  4864		/* Controller radio is available but is currently powered down */
  4865		hdev->amp_status = AMP_STATUS_POWERED_DOWN;
  4866	
  4867		memset(hdev->eir, 0, sizeof(hdev->eir));
  4868		memset(hdev->dev_class, 0, sizeof(hdev->dev_class));
  4869		bacpy(&hdev->random_addr, BDADDR_ANY);
  4870	
  4871		if (was_userchannel)
  4872			hci_dev_set_flag(hdev, HCI_USER_CHANNEL);
  4873	
> 4874		hci_dev_put(hdev);
  4875		return err;
  4876	}
  4877	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (312383 bytes)

Powered by blists - more mailing lists