netdev - Re: [PATCH v3 2/3] net: ethernet: renesas: Add Ethernet Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzQ3gdO/a+jygIDa@lunn.ch>
Date:   Wed, 28 Sep 2022 14:01:05 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] net: ethernet: renesas: Add Ethernet Switch driver

> > How do you direct a frame from the
> > CPU out a specific user port? Via the DMA ring you place it into, or
> > do you need a tag on the frame to indicate its egress port?
> 
> Via the DMA ring.

Are there bits in the ring descriptor which indicate the user port?
Can you set these bits to some other value which causes the switch to
use its MAC table to determine the egress interface?

> > > The PHY is 88E2110 on my environment, so Linux has a driver in
> > > drivers/net/phy/marvell10g.c. However, I guess this is related to
> > > configuration of the PHY chip on the board, it needs to change
> > > the host 7interface mode, but the driver doesn't support it for now.
> > 
> > Please give us more details. The marvell10g driver will change its
> > host side depending on the result of the line side negotiation. It
> > changes the value of phydev->interface to indicate what is it doing on
> > its host side, and you have some control over what modes it will use
> > on the host side. You can probably define its initial host side mode
> > via phy-mode in DT.
> 
> I'm sorry, my explanation was completely wrong.
> My environment needs to change default MAC speed from 2.5G/5G to 1000M.
> The register of 88E2110 is 31.F000.7:6. And sets the register to "10" (1000 Mbps).
> (Default value of the register is "11" (Speed controlled by other register).)

Is this the host side speed? The speed of the SERDES between the
switch and the PHY? Normally, the PHY determines this from the line
side. If the line side is using 2.5G, it will set the host side to
2500BaseX. If the line side is 1G, the host side is likely to be
SGMII.

You have already removed speeds you don't support. So the PHY will not
negotiate 2.5G or 5G. It is limited to 1G. So it should always have
the host side as SGMII. This should be enough to make it work.

    Andrew