netdev - Re: [PATCH net-next v7 2/7] net: add framework to support Ethernet PSE and PDs devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2022 18:00:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        David Jander <david@...tonic.nl>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Robert Marko <robert.marko@...tura.hr>
Subject: Re: [PATCH net-next v7 2/7] net: add framework to support Ethernet
 PSE and PDs devices

On Mon, 26 Sep 2022 13:24:55 +0200 Oleksij Rempel wrote:
> +static inline int pse_controller_register(struct pse_controller_dev *pcdev)
> +{
> +	return -ENOTSUPP;
> +}
> +
> +static inline void pse_controller_unregister(struct pse_controller_dev *pcdev)
> +{
> +}
> +
> +static inline int devm_pse_controller_register(struct device *dev,
> +						 struct pse_controller_dev *pcdev)
> +{
> +	return -ENOTSUPP;
> +}

Presumably only PSE controller drivers would try to register themselves.
Such drivers should depend on the right config, and therefore we don't
need static inline stubs for the register/unregister API.

> +static inline struct pse_control *pse_control_get(struct device *dev)
> +{
> +	return ERR_PTR(-ENOTSUPP);
> +}
> +
> +static inline struct pse_control *devm_pse_control_get( struct device *dev)

nit: extra space after (

> +{
> +	return ERR_PTR(-ENOTSUPP);
> +}

These two I don't see any calls to outside drivers/net/pse-pd/pse_core.c
so they should go from the API until we get an in-tree caller.

> +static inline struct pse_control *of_pse_control_get(struct device_node *node)
> +{
> +	return ERR_PTR(-ENOTSUPP);
> +}

This one should prolly return -ENOENT as noted on patch 4.

If you could sed -i 's/ENOTSUPP/EOPNOTSUPP/' on the patches that'd be
great, I don't think those errno can leak to user space but why risk
it...