netdev - Re: [PATCH v2 net-next 3/6] sfc: optional logging of TC offload errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc338a78-a6da-78ad-ca70-d350e8e13422@gmail.com>
Date:   Wed, 28 Sep 2022 22:14:37 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, linux-net-drivers@....com,
        davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        habetsm.xilinx@...il.com
Subject: Re: [PATCH v2 net-next 3/6] sfc: optional logging of TC offload
 errors

On 28/09/2022 20:07, Jakub Kicinski wrote:
> Let's solve practical problems first :) The cases with multiple devices
> offloading are rare AFAIK.

I know of someone who is working on such a use-case for the Alveo U25N
 and running into Interesting difficulties with the same rule getting
 offloaded twice; they probably would care about getting both devices'
 error messages.  I know the plural of anecdote is not data; but I
 think it's not so rare that we can completely ignore it.

> It's just a buffer on the stack, in the struct, the extack is
> transformed into netlink attrs in the same way regardless.
> Stack use is the only concern, no other impact on those not using it.

Okay, I'd probably go with this approach then.

>> Should I rustle up an RFC patch for one of these, or post an RFD to
>>  the list to canvass other vendors' opinions?
> 
> Would be great! Maybe also grep the archive, cause this came up before.
> Someone was against this in the past, perhaps, perhaps even me :)
> But if it wasn't me we should CC them.

Possibly I'm searching for the wrong magic words, all I can find is
 https://lkml.org/lkml/2021/8/9/747 which is vaguely related at best.

-ed