netdev - RE: [PATCH net-next 0/2] Add helper functions to parse netlink msg of ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2022 03:34:51 +0000
From:   "liujian (CE)" <liujian56@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "dsahern@...nel.org" <dsahern@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 0/2] Add helper functions to parse netlink msg of
 ip_tunnel



> -----Original Message-----
> From: Jakub Kicinski [mailto:kuba@...nel.org]
> Sent: Tuesday, September 27, 2022 10:59 PM
> To: liujian (CE) <liujian56@...wei.com>
> Cc: davem@...emloft.net; yoshfuji@...ux-ipv6.org; dsahern@...nel.org;
> edumazet@...gle.com; pabeni@...hat.com; netdev@...r.kernel.org
> Subject: Re: [PATCH net-next 0/2] Add helper functions to parse netlink msg
> of ip_tunnel
> 
> On Mon, 26 Sep 2022 21:19:42 +0800 Liu Jian wrote:
> > Add helper functions to parse netlinkmsg of ip_tunnel
> >
> > Liu Jian (2):
> >   net: Add helper function to parse netlink msg of ip_tunnel_encap
> >   net: Add helper function to parse netlink msg of ip_tunnel_parm
> >
> >  include/net/ip_tunnels.h | 66
> ++++++++++++++++++++++++++++++++++++++++
> >  net/ipv4/ipip.c          | 62 ++-----------------------------------
> >  net/ipv6/ip6_tunnel.c    | 37 ++--------------------
> >  net/ipv6/sit.c           | 65 ++-------------------------------------
> 
> Do they need to be in a header file? Could you put them in
> net/ipv4/ip_tunnel.c or net/ipv4/ip_tunnel_core.c instead?
The v2 version has been sent. Thanks for your review.