netdev - Re: [PATCH v2] iwlwifi: Track scan_cmd allocation size explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2022 06:29:41 +0000
From:   "Greenman, Gregory" <gregory.greenman@...el.com>
To:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "keescook@...omium.org" <keescook@...omium.org>
CC:     "Golant, Michael" <michael.golant@...el.com>,
        "Goodstein, Mordechay" <mordechay.goodstein@...el.com>,
        "Coelho, Luciano" <luciano.coelho@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Errera, Nathan" <nathan.errera@...el.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "Stern, Avraham" <avraham.stern@...el.com>,
        "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>,
        "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
        "Beker, Ayala" <ayala.beker@...el.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Peer, Ilan" <ilan.peer@...el.com>,
        "Berg, Johannes" <johannes.berg@...el.com>
Subject: Re: [PATCH v2] iwlwifi: Track scan_cmd allocation size explicitly

On Mon, 2022-09-26 at 10:59 +0300, Kalle Valo wrote:
> Kees Cook <keescook@...omium.org> writes:
> 
> > In preparation for reducing the use of ksize(), explicitly track the
> > size of scan_cmd allocations. This also allows for noticing if the scan
> > size changes unexpectedly. Note that using ksize() was already incorrect
> > here, in the sense that ksize() would not match the actual allocation
> > size, which would trigger future run-time allocation bounds checking.
> > (In other words, memset() may know how large scan_cmd was allocated for,
> > but ksize() will return the upper bounds of the actually allocated memory,
> > causing a run-time warning about an overflow.)
> > 
> > Cc: Gregory Greenman <gregory.greenman@...el.com>
> > Cc: Kalle Valo <kvalo@...nel.org>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: Paolo Abeni <pabeni@...hat.com>
> > Cc: Luca Coelho <luciano.coelho@...el.com>
> > Cc: Johannes Berg <johannes.berg@...el.com>
> > Cc: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
> > Cc: Miri Korenblit <miriam.rachel.korenblit@...el.com>
> > Cc: Ilan Peer <ilan.peer@...el.com>
> > Cc: linux-wireless@...r.kernel.org
> > Cc: netdev@...r.kernel.org
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> 
> Gregory, can I take this directly to wireless-next?
> 

Acked-by: Gregory Greenman <gregory.greenman@...el.com>

Yes, thanks!