netdev - Re: [PATCH net-next] docs: netlink: clarify the historical baggage of Netlink flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a93cea13-21e9-f714-270c-559d51f68716@wifirst.fr>
Date:   Wed, 28 Sep 2022 10:04:46 +0200
From:   Florent Fourcot <florent.fourcot@...irst.fr>
To:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com
Cc:     Johannes Berg <johannes@...solutions.net>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Guillaume Nault <gnault@...hat.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net-next] docs: netlink: clarify the historical baggage of
 Netlink flags

Hello,

About NLM_F_EXCL, I'm not sure that my comment is relevant for your 
intro.rst document, but it has another usage in ipset submodule. For 
IPSET_CMD_DEL, setting NLM_F_EXCL means "raise an error if entry does 
not exist before the delete".

For IPSET_CMD_ADD, setting NLM_F_EXCL will raises an error if it already 
exists (that is fine with your documentation). But without the flag, 
IPSET_CMD_ADD is more or less like a "replace" operation, since one can 
update fields like counters values (IPSET_ATTR_PACKETS / 
IPSET_ATTR_BYTES), without using NLM_F_REPLACE flag.

Best regards

-- 
*Ce message et toutes les pièces jointes (ci-après le "message") sont 
établis à l’intention exclusive des destinataires désignés. Il contient des 
informations confidentielles et pouvant être protégé par le secret 
professionnel. Si vous recevez ce message par erreur, merci d'en avertir 
immédiatement l'expéditeur et de détruire le message. Toute utilisation de 
ce message non conforme à sa destination, toute diffusion ou toute 
publication, totale ou partielle, est interdite, sauf autorisation expresse 
de l'émetteur*