netdev - Re: [PATCH net-next 4/6] netlink: add a proto specification for FOU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c64b772-7b2b-77f8-4523-4408e0b3bf8a@6wind.com>
Date:   Thu, 29 Sep 2022 11:02:51 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        robh@...nel.org, johannes@...solutions.net, ecree.xilinx@...il.com,
        stephen@...workplumber.org, sdf@...gle.com, f.fainelli@...il.com,
        fw@...len.de, linux-doc@...r.kernel.org, razor@...ckwall.org,
        gnault@...hat.com
Subject: Re: [PATCH net-next 4/6] netlink: add a proto specification for FOU


Le 29/09/2022 à 03:11, Jakub Kicinski a écrit :
> FOU has a reasonably modern Genetlink family. Add a spec.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  Documentation/netlink/specs/fou.yaml | 128 +++++++++++++++++++++++++++
>  1 file changed, 128 insertions(+)
>  create mode 100644 Documentation/netlink/specs/fou.yaml
> 
> diff --git a/Documentation/netlink/specs/fou.yaml b/Documentation/netlink/specs/fou.yaml
> new file mode 100644
> index 000000000000..266c386eedf3
> --- /dev/null
> +++ b/Documentation/netlink/specs/fou.yaml
> @@ -0,0 +1,128 @@
> +name: fou
> +
> +protocol: genetlink-legacy
> +
> +doc: |
> +  Foo-over-UDP.
> +
> +c-family-name: fou-genl-name
> +c-version-name: fou-genl-version
> +max-by-define: true
> +kernel-policy: global
> +
> +definitions:
> +  -
> +    type: enum
> +    name: encap_type
> +    name-prefix: fou-encap-
> +    enum-name:
> +    entries: [ unspec, direct, gue ]
> +
> +attribute-sets:
> +  -
> +    name: fou
> +    name-prefix: fou-attr-
> +    attributes:
> +      -
> +        name: unspec
> +        type: unused
The first attribute should always be unspec/unused. Maybe it could be
automatically generated?

> +      -
> +        name: port
> +        type: u16
> +        byte-order: big-endian
> +      -
> +        name: af
> +        type: u8
> +      -
> +        name: ipproto
> +        type: u8
> +      -
> +        name: type
> +        type: u8
> +      -
> +        name: remcsum_nopartial
> +        type: flag
> +      -
> +        name: local_v4
> +        type: u32
> +      -
> +        name: local_v6
> +        type: binary
> +        checks:
> +          min-len: 16
> +      -
> +        name: peer_v4
> +        type: u32
> +      -
> +        name: peer_v6
> +        type: binary
> +        checks:
> +          min-len: 16
> +      -
> +        name: peer_port
> +        type: u16
> +        byte-order: big-endian
> +      -
> +        name: ifindex
> +        type: s32
> +
> +operations:
> +  list:
> +    -
> +      name: unspec
> +      doc: unused

To what correspond this name?
It helps to name the generated operations array?
Something else than 'const struct genl_small_ops fou_ops[3]'?