netdev - Re: [PATCH net-next 4/6] netlink: add a proto specification for FOU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220929074105.168d944e@kernel.org>
Date:   Thu, 29 Sep 2022 07:41:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, robh@...nel.org, johannes@...solutions.net,
        ecree.xilinx@...il.com, stephen@...workplumber.org, sdf@...gle.com,
        f.fainelli@...il.com, fw@...len.de, linux-doc@...r.kernel.org,
        razor@...ckwall.org, gnault@...hat.com
Subject: Re: [PATCH net-next 4/6] netlink: add a proto specification for FOU

On Thu, 29 Sep 2022 11:02:51 +0200 Nicolas Dichtel wrote:
> > +operations:
> > +  list:
> > +    -
> > +      name: unspec
> > +      doc: unused  
> 
> To what correspond this name?
> It helps to name the generated operations array?
> Something else than 'const struct genl_small_ops fou_ops[3]'?

Same as the attr, it just reserves zero FWIW, never actually used in
the code I've grepped:

linux$ git grep FOU_CMD_UNSPEC
include/uapi/linux/fou.h:       FOU_CMD_UNSPEC,

iproute2$ git grep FOU_CMD_UNSPEC
include/uapi/linux/fou.h:       FOU_CMD_UNSPEC,

BTW thanks for asking, I noticed I mistyped the documentation,
type is 'unused', in the docs I said 'unspec'.