netdev - Re: [PATCH net-next 4/6] net: microchip: sparx5: add support for apptrust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202209292254.gNhHiNZs-lkp@intel.com>
Date:   Thu, 29 Sep 2022 23:07:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Machon <daniel.machon@...rochip.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, petrm@...dia.com,
        maxime.chevallier@...tlin.com, thomas.petazzoni@...tlin.com,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        lars.povlsen@...rochip.com, Steen.Hegelund@...rochip.com,
        daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com,
        joe@...ches.com, linux@...linux.org.uk,
        horatiu.vultur@...rochip.com, Julia.Lawall@...ia.fr,
        vladimir.oltean@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next 4/6] net: microchip: sparx5: add support for
 apptrust

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Machon/Add-new-PCP-and-APPTRUST-attributes-to-dcbnl/20220929-195750
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0e9804cff18223e750f3af52a2701945bb362f55
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b0191a19df159a4f61797bb6d98052d4f27a9894
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniel-Machon/Add-new-PCP-and-APPTRUST-attributes-to-dcbnl/20220929-195750
        git checkout b0191a19df159a4f61797bb6d98052d4f27a9894
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/ethernet/microchip/sparx5/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c:196:5: warning: no previous prototype for 'sparx5_dcb_init' [-Wmissing-prototypes]
     196 | int sparx5_dcb_init(struct sparx5 *sparx5)
         |     ^~~~~~~~~~~~~~~


vim +/sparx5_dcb_init +196 drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c

   195	
 > 196	int sparx5_dcb_init(struct sparx5 *sparx5)
   197	{
   198		struct sparx5_port *port;
   199		int i;
   200	
   201		for (i = 0; i < SPX5_PORTS; i++) {
   202			port = sparx5->ports[i];
   203			if (!port)
   204				continue;
   205			/* Initialize [dscp, pcp] default trust */
   206			apptrust[port->portno] = &apptrust_conf[3];
   207		}
   208	
   209		return sparx5_dcb_app_update(port->ndev);
   210	}
   211	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (241700 bytes)