netdev - Re: [net-next PATCH v2 6/8] octeontx2-af: cn10k: mcs: Handle MCS block interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220929091302.13d3248e@kernel.org>
Date:   Thu, 29 Sep 2022 09:13:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Subbaraya Sundeep <sbhatta@...vell.com>
Cc:     <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <sgoutham@...vell.com>,
        <naveenm@...vell.com>, Geetha sowjanya <gakula@...vell.com>,
        Vamsi Attunuru <vattunuru@...vell.com>
Subject: Re: [net-next PATCH v2 6/8] octeontx2-af: cn10k: mcs: Handle MCS
 block interrupts

On Wed, 28 Sep 2022 09:28:08 +0530 Subbaraya Sundeep wrote:
> From: Geetha sowjanya <gakula@...vell.com>
> 
> Hardware triggers an interrupt for events like PN wrap to zero,
> PN crosses set threshold. This interrupt is received
> by the MCS_AF. MCS AF then finds the PF/VF to which SA is mapped
> and notifies them using mcs_intr_notify mbox message.
> 
> PF/VF using mcs_intr_cfg mbox can configure the list
> of interrupts for which they want to receive the
> notification from AF.

clang is still upset at a couple of patches here, for instance:

drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c:102:6: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
        if (err)
            ^~~
drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c:87:9: note: initialize the variable 'err' to silence this warning
        int err, pf;
               ^
                = 0