netdev - Re: [PATCH] vhost/vsock: Use kvmalloc/kvfree for larger packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220929110740.77942060@kernel.org>
Date:   Thu, 29 Sep 2022 11:07:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Stefano Garzarella <sgarzare@...hat.com>,
        "Junichi Uekawa ( 上川純一) " <uekawa@...gle.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, davem@...emloft.net,
        netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        kvm@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
        linux-kernel@...r.kernel.org,
        Bobby Eshleman <bobby.eshleman@...il.com>
Subject: Re: [PATCH] vhost/vsock: Use kvmalloc/kvfree for larger packets.

On Thu, 29 Sep 2022 12:25:14 -0400 Michael S. Tsirkin wrote:
> On Thu, Sep 29, 2022 at 09:07:31AM -0700, Jakub Kicinski wrote:
> > On Thu, 29 Sep 2022 03:49:18 -0400 Michael S. Tsirkin wrote:  
> > > net tree would be preferable, my pull for this release is kind of ready ... kuba?  
> > 
> > If we're talking about 6.1 - we can take it, no problem.  
> 
> I think they want it in 6.0 as it fixes a crash.

I thought it's just an OOM leading to send failure. Junichi could you
repost with the tags collected and the header for that stack trace
included? The line that says it's just an OOM...

"someone tried to alloc >32kB because it worked on a freshly booted
system" kind of cases are a dime a dozen, no?..