netdev - Re: [PATCH net-next] selftests/tc-testing: update qdisc/cls/action features in config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <663b6106-863a-2782-a6ba-0728d2897669@huawei.com>
Date:   Thu, 29 Sep 2022 12:04:33 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Victor Nogueira <victor@...atatu.com>
CC:     <netdev@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
        <shuah@...nel.org>, <weiyongjun1@...wei.com>,
        <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] selftests/tc-testing: update qdisc/cls/action
 features in config



On 2022/9/29 9:48, Victor Nogueira wrote:
> On Wed, Sep 28, 2022 at 5:29 AM Zhengchao Shao <shaozhengchao@...wei.com> wrote:
>>
>> Since three patchsets "add tc-testing test cases", "refactor duplicate
>> codes in the tc cls walk function", and "refactor duplicate codes in the
>> qdisc class walk function" are merged to net-next tree, the list of
>> supported features needs to be updated in config file.
>>
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> ---
>>   tools/testing/selftests/tc-testing/config | 25 ++++++++++++++++++++++-
>>   1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config
>> index 2b2c2a835757..5ec7418a3c29 100644
>> --- a/tools/testing/selftests/tc-testing/config
>> +++ b/tools/testing/selftests/tc-testing/config
>> @@ -13,15 +13,28 @@ CONFIG_NET_SCHED=y
>>   # Queueing/Scheduling
>>   #
>>   CONFIG_NET_SCH_ATM=m
>> +CONFIG_NET_SCH_CAKE=m
>> +CONFIG_NET_SCH_CBQ=m
>> +CONFIG_NET_SCH_CBS=m
>>   CONFIG_NET_SCH_CHOKE=m
>>   CONFIG_NET_SCH_CODEL=m
>> +CONFIG_NET_SCH_DRR=m
>> +CONFIG_NET_SCH_DSMARK=m
>>   CONFIG_NET_SCH_ETF=m
>>   CONFIG_NET_SCH_FQ=m
>> +CONFIG_NET_SCH_FQ_CODEL=m
>>   CONFIG_NET_SCH_GRED=m
>> +CONFIG_NET_SCH_HFSC=m
>>   CONFIG_NET_SCH_HHF=m
>> +CONFIG_NET_SCH_HTB=m
>> +CONFIG_NET_SCH_INGRESS=m
>> +CONFIG_NET_SCH_MQPRIO=m
>> +CONFIG_NET_SCH_MULTIQ=m
>> +CONFIG_NET_NET_SCH_NETEM=m
> 
> I think it should be CONFIG_NET_SCH_NETEM.
> 
>> +CONFIG_NET_SCH_PIE=m
>>   CONFIG_NET_SCH_PLUG=m
>>   CONFIG_NET_SCH_PRIO=m
>> -CONFIG_NET_SCH_INGRESS=m
>> +CONFIG_NET_SCH_QFQ=m
>>   CONFIG_NET_SCH_SFB=m
>>   CONFIG_NET_SCH_SFQ=m
>>   CONFIG_NET_SCH_SKBPRIO=m
>> @@ -37,6 +50,15 @@ CONFIG_NET_CLS_FW=m
>>   CONFIG_NET_CLS_U32=m
>>   CONFIG_CLS_U32_PERF=y
>>   CONFIG_CLS_U32_MARK=y
>> +CONFIG_NET_CLS_BASIC=m
>> +CONFIG_NET_CLS_BPF=m
>> +CONFIG_NET_CLS_CGROUP=m
>> +CONFIG_NET_CLS_FLOW=m
>> +CONFIG_NET_CLS_FLOWER=m
>> +CONFIG_NET_CLS_MATCHALL=m
>> +CONFIG_NET_CLS_ROUTE4=m
>> +CONFIG_NET_CLS_RSVP=m
>> +CONFGI_NET_CLS_TCINDEX=m
> 
> I think there's a typo here.
> Should be CONFIG_NET_CLS_TCINDEX.
> 

Oh, My mistake. I will change in V2. Thank you, Victor.

Zhengchao Shao
>>   CONFIG_NET_EMATCH=y
>>   CONFIG_NET_EMATCH_STACK=32
>>   CONFIG_NET_EMATCH_CMP=m
>> @@ -68,6 +90,7 @@ CONFIG_NET_ACT_IFE=m
>>   CONFIG_NET_ACT_TUNNEL_KEY=m
>>   CONFIG_NET_ACT_CT=m
>>   CONFIG_NET_ACT_MPLS=m
>> +CONFIG_NET_ACT_GATE=m
>>   CONFIG_NET_IFE_SKBMARK=m
>>   CONFIG_NET_IFE_SKBPRIO=m
>>   CONFIG_NET_IFE_SKBTCINDEX=m
>> --
>> 2.17.1
>>
>