netdev - Re: [CFT][PATCH] proc: Update /proc/net to point at the accessing threads network namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Yzb2nyYK94gcOKOR@localhost.localdomain>
Date:   Fri, 30 Sep 2022 17:01:03 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     viro@...iv.linux.org.uk
Cc:     ebiederm@...ssion.com, torvalds@...ux-foundation.org,
        David.Laight@...lab.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, serge@...lyn.com
Subject: Re: [CFT][PATCH] proc: Update /proc/net to point at the accessing
 threads network namespace

Al wrote:

> Just to troll adobriyan a bit:
> 
> static const char *dynamic_get_link(struct delayed_call *done,
> 				    bool is_rcu,
> 				    const char *fmt, ...)
> {
> 	va_list args;
> 	char *body;
> 
> 	va_start(args, fmt);
> 	body = kvasprintf(is_rcu ? GFP_ATOMIC : GFP_KERNEL, fmt, args);
> 	va_end(args);

Ouch... Double pass over data. Who wrote this?

> 
> 	if (unlikely(!body))
> 		return is_rcu ? ERR_PTR(-ECHILD) : ERR_PTR(-ENOMEM);
> 	set_delayed_call(done, kfree_link, body);
> 	return body;
> }