netdev - Re: new warning caused by ("net-sysfs: update the queue counts in the unregistration path")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220929191137.7393bee4@kernel.org>
Date:   Thu, 29 Sep 2022 19:11:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kevin Mitchell <kevmitch@...sta.com>
Cc:     Antoine Tenart <atenart@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: new warning caused by ("net-sysfs: update the queue counts in
 the unregistration path")

On Wed, 28 Sep 2022 16:20:33 -0700 Kevin Mitchell wrote:
> > As you said and looking around queue 0 is somewhat special and used as a
> > fallback. My suggestion would be to 1) check if the above race is
> > expected 2) if yes, a possible solution would be not to warn when
> > real_num_tx_queues == 0 as in such cases selecting queue 0 would be the
> > expected fallback (and you might want to check places like [1]).  
> 
> Yes this is exactly where this is happening and that sounds like a good idea to
> me. As far as I can tell, the message is completely innocuous. If there really
> are no cases where it is useful to have this warning for real_num_tx_queues ==
> 0, I could submit a patch to not emit it in that case.

SGTM, FWIW.