lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 30 Sep 2022 23:52:27 +0800
From:   kernel test robot <>
To:     Praghadeesh T K S <>,
        Boris Pismenny <>,
        Saeed Mahameed <>,
        Leon Romanovsky <>,
        "David S. Miller" <>,
        Eric Dumazet <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,,
Subject: Re: [PATCH] net: ethernet/mellanox: fix dereference before null check

Hi Praghadeesh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20220929]
[cannot apply to net/master linus/master v6.0-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: 10c2aba89cc0535b23ebc795f44b8b8b16785ec9
config: s390-allyesconfig
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add linux-review
        git fetch --no-tags linux-review Praghadeesh-T-K-S/net-ethernet-mellanox-fix-dereference-before-null-check/20220930-194848
        git checkout b435d653648a9712105eb8d3c65fb3a0b301ab0e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c: In function 'mlx5e_macsec_cleanup':
>> drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c:1853:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    1853 |         struct mlx5_core_dev *mdev = macsec->mdev;
         |         ^~~~~~

vim +1853 drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c

  1846	void mlx5e_macsec_cleanup(struct mlx5e_priv *priv)
  1847	{
  1848		struct mlx5e_macsec *macsec = priv->macsec;
  1850		if (!macsec)
  1851			return;
> 1853		struct mlx5_core_dev *mdev = macsec->mdev;

0-DAY CI Kernel Test Service

View attachment "config" of type "text/plain" (305665 bytes)

Powered by blists - more mailing lists