netdev - Re: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzdPgL1ghbyp3ypv@lunn.ch>
Date:   Fri, 30 Sep 2022 22:20:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Shenwei Wang <shenwei.wang@....com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Wei Fang <wei.fang@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: Re: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX
 buffers

On Fri, Sep 30, 2022 at 08:07:55PM +0000, Shenwei Wang wrote:
> 
> 
> > -----Original Message-----
> > From: Andrew Lunn <andrew@...n.ch>
> > Sent: Friday, September 30, 2022 3:05 PM
> > To: Shenwei Wang <shenwei.wang@....com>
> > Cc: David S . Miller <davem@...emloft.net>; Eric Dumazet
> > <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> > <pabeni@...hat.com>; Alexei Starovoitov <ast@...nel.org>; Daniel Borkmann
> > <daniel@...earbox.net>; Jesper Dangaard Brouer <hawk@...nel.org>; John
> > Fastabend <john.fastabend@...il.com>; Wei Fang <wei.fang@....com>;
> > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; imx@...ts.linux.dev
> > Subject: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers
> > 
> > Caution: EXT Email
> > 
> > > -static bool fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> > > -                            struct bufdesc *bdp, u32 length, bool swap)
> > > +static bool __maybe_unused
> > > +fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> > > +                struct bufdesc *bdp, u32 length, bool swap)
> > >  {
> > 
> > Why add __maybe_unused? If its not used, remove it. We don't leave dead
> > functions in the code.
> > 
> 
> I was thinking to remove them by a separate patch once the page pool solution is accepted.

Then say that in the commit message. The commit message is how you
answer questions the Maintainers might have, without them having to
ask.

What is small packet performance like on the imx6? If you provide some
numbers as to how small the reduction in performance is, we can decide
if the reduction in complexity is worth it.

   Andrew