netdev - Re: [PATCH net-next v2 3/6] net: microchip: sparx5: add support for offloading pcp table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 1 Oct 2022 04:44:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Machon <daniel.machon@...rochip.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, petrm@...dia.com,
        maxime.chevallier@...tlin.com, thomas.petazzoni@...tlin.com,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        lars.povlsen@...rochip.com, Steen.Hegelund@...rochip.com,
        daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com,
        joe@...ches.com, linux@...linux.org.uk,
        horatiu.vultur@...rochip.com, Julia.Lawall@...ia.fr,
        vladimir.oltean@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v2 3/6] net: microchip: sparx5: add support for
 offloading pcp table

Hi Daniel,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Machon/Add-new-PCP-and-APPTRUST-attributes-to-dcbnl/20220930-024511
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 510bbf82f8dc36804114873d30ed1d0c8533af81
config: sh-randconfig-r024-20220926
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/58449d0d89f40e1868bbac5d16cb1be8e396cf68
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniel-Machon/Add-new-PCP-and-APPTRUST-attributes-to-dcbnl/20220930-024511
        git checkout 58449d0d89f40e1868bbac5d16cb1be8e396cf68
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   cc1: warning: arch/sh/include/mach-rsk: No such file or directory [-Wmissing-include-dirs]
   cc1: warning: arch/sh/include/mach-rsk: No such file or directory [-Wmissing-include-dirs]
   drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c: In function 'sparx5_create_netdev':
>> drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c:261:13: error: 'struct net_device' has no member named 'dcbnl_ops'
     261 |         ndev->dcbnl_ops = &sparx5_dcbnl_ops;
         |             ^~


vim +261 drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c

   239	
   240	struct net_device *sparx5_create_netdev(struct sparx5 *sparx5, u32 portno)
   241	{
   242		struct sparx5_port *spx5_port;
   243		struct net_device *ndev;
   244	
   245		ndev = devm_alloc_etherdev_mqs(sparx5->dev, sizeof(struct sparx5_port),
   246					       SPX5_PRIOS, 1);
   247		if (!ndev)
   248			return ERR_PTR(-ENOMEM);
   249	
   250		ndev->hw_features |= NETIF_F_HW_TC;
   251		ndev->features |= NETIF_F_HW_TC;
   252	
   253		SET_NETDEV_DEV(ndev, sparx5->dev);
   254		spx5_port = netdev_priv(ndev);
   255		spx5_port->ndev = ndev;
   256		spx5_port->sparx5 = sparx5;
   257		spx5_port->portno = portno;
   258	
   259		ndev->netdev_ops = &sparx5_port_netdev_ops;
   260		ndev->ethtool_ops = &sparx5_ethtool_ops;
 > 261		ndev->dcbnl_ops = &sparx5_dcbnl_ops;
   262	
   263		eth_hw_addr_gen(ndev, sparx5->base_mac, portno + 1);
   264	
   265		return ndev;
   266	}
   267	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (146583 bytes)