| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220930204851.1910059-1-jacob.e.keller@intel.com>
Date: Fri, 30 Sep 2022 13:48:42 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: netdev@...r.kernel.org
Cc: Jacob Keller <jacob.e.keller@...el.com>,
"K. Y. Srinivasan" <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
Stephen Hemminger <sthemmin@...rosoft.com>,
Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
Tom Lendacky <thomas.lendacky@....com>,
Shyam Sundar S K <Shyam-sundar.S-k@....com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Siva Reddy Kallam <siva.kallam@...adcom.com>,
Prashant Sreedharan <prashant@...adcom.com>,
Michael Chan <mchan@...adcom.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
Tariq Toukan <tariqt@...dia.com>,
Saeed Mahameed <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>,
Bryan Whitehead <bryan.whitehead@...rochip.com>,
Sergey Shtylyov <s.shtylyov@....ru>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Richard Cochran <richardcochran@...il.com>,
Vivek Thampi <vithampi@...are.com>,
VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
Jie Wang <wangjie125@...wei.com>,
Guangbin Huang <huangguangbin2@...wei.com>,
Eran Ben Elisha <eranbe@...dia.com>,
Aya Levin <ayal@...dia.com>,
Cai Huoqing <cai.huoqing@...ux.dev>,
Biju Das <biju.das.jz@...renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Phil Edworthy <phil.edworthy@...esas.com>,
Jiasheng Jiang <jiasheng@...as.ac.cn>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Wan Jiabing <wanjiabing@...o.com>,
Lv Ruyi <lv.ruyi@....com.cn>, Arnd Bergmann <arnd@...db.de>
Subject: [net-next v2 0/9] ptp: convert drivers to .adjfine
Many drivers implementing PTP have not yet migrated to the new .adjfine
frequency adjustment implementation.
A handful of these drivers use hardware with a simple increment value which
is adjusted by multiplying by the adjustment factor and then dividing by
1 billion. This calculation is very easy to convert to .adjfine, by simply
updating the divisor.
Introduce new helper functions, diff_by_scaled_ppm and adjust_by_scaled_ppm
which perform the most common calculations used by drivers for this purpose.
The adjust_by_scaled_ppm takes the base increment and scaled PPM value, and
calculates the new increment to use.
A few drivers need the difference and direction rather than a raw increment
value. The diff_by_scaled_ppm calculates the difference and returns true if
it should be a subtraction, false otherwise. This most closely aligns with
existing driver implementations.
I previously submitted v1 of this series at [1], and got some feedback only
on a handful of drivers. In the interest of merging the changes which have
received feedback, I've dropped the following drivers out of this send:
* ptp_phc
* ptp_ipx46x
* tg3
* hclge
* stmac
* cpts
I plan to submit those drivers changes again at a later date. As before,
there are some drivers which are not trivial to convert to the new helper
functions. While they may be able to work, their implementation is different
and I lack the hardware or datasheets to determine what the correct
implementation would be.
* drivers/net/ethernet/broadcom/bnx2x
* drivers/net/ethernet/broadcom/bnxt
* drivers/net/ethernet/cavium/liquidio
* drivers/net/ethernet/chelsio/cxgb4
* drivers/net/ethernet/freescale
* drivers/net/ethernet/qlogic/qed
* drivers/net/ethernet/qlogic/qede
* drivers/net/ethernet/sfc
* drivers/net/ethernet/sfc/siena
* drivers/net/ethernet/ti/am65-cpts.c
* drivers/ptp/ptp_dte.c
My end goal is to drop the .adjfreq implementation entirely, and to that end
I plan on modifying these drivers in the future to directly use
scaled_ppm_to_ppb as the simplest method to convert them.
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>
Cc: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: Stephen Hemminger <sthemmin@...rosoft.com>
Cc: Wei Liu <wei.liu@...nel.org>
Cc: Dexuan Cui <decui@...rosoft.com>
Cc: Tom Lendacky <thomas.lendacky@....com>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@....com>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: Eric Dumazet <edumazet@...gle.com>
Cc: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>
Cc: Siva Reddy Kallam <siva.kallam@...adcom.com>
Cc: Prashant Sreedharan <prashant@...adcom.com>
Cc: Michael Chan <mchan@...adcom.com>
Cc: Yisen Zhuang <yisen.zhuang@...wei.com>
Cc: Salil Mehta <salil.mehta@...wei.com>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: Tariq Toukan <tariqt@...dia.com>
Cc: Saeed Mahameed <saeedm@...dia.com>
Cc: Leon Romanovsky <leon@...nel.org>
Cc: Bryan Whitehead <bryan.whitehead@...rochip.com>
Cc: Sergey Shtylyov <s.shtylyov@....ru>
Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: Jose Abreu <joabreu@...opsys.com>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc: Richard Cochran <richardcochran@...il.com>
Cc: Vivek Thampi <vithampi@...are.com>
Cc: VMware PV-Drivers Reviewers <pv-drivers@...are.com>
Cc: Jie Wang <wangjie125@...wei.com>
Cc: Jacob Keller <jacob.e.keller@...el.com>
Cc: Guangbin Huang <huangguangbin2@...wei.com>
Cc: Eran Ben Elisha <eranbe@...dia.com>
Cc: Aya Levin <ayal@...dia.com>
Cc: Cai Huoqing <cai.huoqing@...ux.dev>
Cc: Biju Das <biju.das.jz@...renesas.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc: Phil Edworthy <phil.edworthy@...esas.com>
Cc: Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>
Cc: Wan Jiabing <wanjiabing@...o.com>
Cc: Lv Ruyi <lv.ruyi@....com.cn>
Cc: Arnd Bergmann <arnd@...db.de>
Jacob Keller (9):
ptp: add missing documentation for parameters
ptp: introduce helpers to adjust by scaled parts per million
drivers: convert unsupported .adjfreq to .adjfine
ptp: mlx4: convert to .adjfine and adjust_by_scaled_ppm
ptp: mlx5: convert to .adjfine and adjust_by_scaled_ppm
ptp: lan743x: remove .adjfreq implementation
ptp: lan743x: use diff_by_scaled_ppm in .adjfine implementation
ptp: ravb: convert to .adjfine and adjust_by_scaled_ppm
ptp: xgbe: convert to .adjfine and adjust_by_scaled_ppm
drivers/hv/hv_util.c | 4 +-
drivers/net/ethernet/amd/xgbe/xgbe-ptp.c | 20 ++-----
drivers/net/ethernet/intel/e1000e/ptp.c | 16 ++----
drivers/net/ethernet/intel/i40e/i40e_ptp.c | 17 ++----
drivers/net/ethernet/intel/ice/ice_ptp.c | 18 +------
drivers/net/ethernet/intel/igb/igb_ptp.c | 18 +------
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 24 ++-------
drivers/net/ethernet/mellanox/mlx4/en_clock.c | 29 ++++------
.../ethernet/mellanox/mlx5/core/lib/clock.c | 22 +++-----
drivers/net/ethernet/microchip/lan743x_ptp.c | 54 +++----------------
drivers/net/ethernet/renesas/ravb_ptp.c | 17 ++----
drivers/ptp/ptp_kvm_common.c | 4 +-
drivers/ptp/ptp_vmw.c | 4 +-
include/linux/ptp_clock_kernel.h | 53 ++++++++++++++++++
14 files changed, 105 insertions(+), 195 deletions(-)
base-commit: 915b96c52763e2988e6368b538b487a7138b8fa4
--
2.37.1.394.gc50926e1f488
Powered by blists - more mailing lists