netdev - Re: [PATCH v2 bpf-next] net: netfilter: move bpf_ct_set_nat_info kfunc in nf_nat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2022 19:35:34 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Martin KaFai Lau <martin.lau@...ux.dev>,
        Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, davem@...emloft.net, kuba@...nel.org,
        edumazet@...gle.com, pabeni@...hat.com, pablo@...filter.org,
        fw@...len.de, netfilter-devel@...r.kernel.org,
        lorenzo.bianconi@...hat.com, brouer@...hat.com, toke@...hat.com,
        memxor@...il.com, nathan@...nel.org, ykaliuta@...hat.com,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH v2 bpf-next] net: netfilter: move bpf_ct_set_nat_info
 kfunc in nf_nat_bpf.c

Martin KaFai Lau wrote:
> On 9/29/22 3:38 PM, Lorenzo Bianconi wrote:
> > Remove circular dependency between nf_nat module and nf_conntrack one
> > moving bpf_ct_set_nat_info kfunc in nf_nat_bpf.c
> > 
> > Fixes: 0fabd2aa199f ("net: netfilter: add bpf_ct_set_nat_info kfunc helper")
> > Suggested-by: Kumar Kartikeya Dwivedi <memxor@...il.com>
> > Tested-by: Nathan Chancellor <nathan@...nel.org>
> > Tested-by: Yauheni Kaliuta <ykaliuta@...hat.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> > ---
> > Changes since v1:
> > - move register_nf_nat_bpf declaration in nf_conntrack_bpf.h
> > ---
> >   include/net/netfilter/nf_conntrack_bpf.h | 19 ++++++
> >   net/netfilter/Makefile                   |  6 ++
> >   net/netfilter/nf_conntrack_bpf.c         | 50 ---------------
> >   net/netfilter/nf_nat_bpf.c               | 79 ++++++++++++++++++++++++
> >   net/netfilter/nf_nat_core.c              |  4 +-
> 
> lgtm.  It should have addressed Pablo's comment in v1.  Can the netfilter team 
> give an ack for the patch?
> 

Also lgtm

Acked-by: John Fastabend <john.fastabend@...il.com>