| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Sep 2022 06:51:18 +0800
From: kernel test robot <lkp@...el.com>
To: Juhee Kang <claudiajkang@...il.com>, netdev@...r.kernel.org,
simon.horman@...igine.com, kuba@...nel.org, davem@...emloft.net,
edumazet@...gle.com, pabeni@...hat.com
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
skhan@...uxfoundation.org, Juhee Kang <claudiajkang@...il.com>
Subject: Re: [PATCH net-next v2] net: remove unused netdev_unregistering()
Hi Juhee,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Juhee-Kang/net-remove-unused-netdev_unregistering/20220929-002052
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b9a5cbf8ba24e88071a97a51a09ef5cdf0d1f6a1
config: hexagon-randconfig-r045-20220925
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6f0c5fa42e20f2c01356f5e590908509a93a3712
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Juhee-Kang/net-remove-unused-netdev_unregistering/20220929-002052
git checkout 6f0c5fa42e20f2c01356f5e590908509a93a3712
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/core/ net/ethtool/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> net/core/dev.c:2889:45: error: call to undeclared function 'netdev_unregistering'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
^
net/core/dev.c:5788:7: error: call to undeclared function 'netdev_unregistering'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (netdev_unregistering(skb->dev)) {
^
net/core/dev.c:5797:7: error: call to undeclared function 'netdev_unregistering'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (netdev_unregistering(skb->dev)) {
^
net/core/dev.c:10710:6: error: call to undeclared function 'netdev_unregistering'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (netdev_unregistering(dev)) {
^
4 errors generated.
--
>> net/core/net-sysfs.c:1714:7: error: call to undeclared function 'netdev_unregistering'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
WARN(netdev_unregistering(dev) && new_num > old_num,
^
1 error generated.
--
>> net/ethtool/netlink.c:43:36: error: call to undeclared function 'netdev_unregistering'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (!netif_device_present(dev) || netdev_unregistering(dev)) {
^
1 error generated.
vim +/netdev_unregistering +2889 net/core/dev.c
ffcfe25bb50f27 Alexander Duyck 2018-07-09 2874
f0796d5c73e597 John Fastabend 2010-07-01 2875 /*
f0796d5c73e597 John Fastabend 2010-07-01 2876 * Routine to help set real_num_tx_queues. To avoid skbs mapped to queues
3a053b1a30dcb4 Gal Pressman 2018-02-28 2877 * greater than real_num_tx_queues stale skbs on the qdisc must be flushed.
f0796d5c73e597 John Fastabend 2010-07-01 2878 */
e6484930d7c73d Tom Herbert 2010-10-18 2879 int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
f0796d5c73e597 John Fastabend 2010-07-01 2880 {
ac5b70198adc25 Jakub Kicinski 2018-02-12 2881 bool disabling;
1d24eb4815d1e0 Tom Herbert 2010-11-21 2882 int rc;
1d24eb4815d1e0 Tom Herbert 2010-11-21 2883
ac5b70198adc25 Jakub Kicinski 2018-02-12 2884 disabling = txq < dev->real_num_tx_queues;
ac5b70198adc25 Jakub Kicinski 2018-02-12 2885
e6484930d7c73d Tom Herbert 2010-10-18 2886 if (txq < 1 || txq > dev->num_tx_queues)
e6484930d7c73d Tom Herbert 2010-10-18 2887 return -EINVAL;
f0796d5c73e597 John Fastabend 2010-07-01 2888
ae54a563ec4981 Juhee Kang 2022-09-24 @2889 if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
e6484930d7c73d Tom Herbert 2010-10-18 2890 ASSERT_RTNL();
e6484930d7c73d Tom Herbert 2010-10-18 2891
1d24eb4815d1e0 Tom Herbert 2010-11-21 2892 rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
1d24eb4815d1e0 Tom Herbert 2010-11-21 2893 txq);
bf264145101034 Tom Herbert 2010-11-26 2894 if (rc)
bf264145101034 Tom Herbert 2010-11-26 2895 return rc;
bf264145101034 Tom Herbert 2010-11-26 2896
4f57c087de9b46 John Fastabend 2011-01-17 2897 if (dev->num_tc)
4f57c087de9b46 John Fastabend 2011-01-17 2898 netif_setup_tc(dev, txq);
4f57c087de9b46 John Fastabend 2011-01-17 2899
1e080f17750d10 Jakub Kicinski 2021-09-13 2900 dev_qdisc_change_real_num_tx(dev, txq);
1e080f17750d10 Jakub Kicinski 2021-09-13 2901
ac5b70198adc25 Jakub Kicinski 2018-02-12 2902 dev->real_num_tx_queues = txq;
ac5b70198adc25 Jakub Kicinski 2018-02-12 2903
ac5b70198adc25 Jakub Kicinski 2018-02-12 2904 if (disabling) {
ac5b70198adc25 Jakub Kicinski 2018-02-12 2905 synchronize_net();
f0796d5c73e597 John Fastabend 2010-07-01 2906 qdisc_reset_all_tx_gt(dev, txq);
024e9679a2daaa Alexander Duyck 2013-01-10 2907 #ifdef CONFIG_XPS
024e9679a2daaa Alexander Duyck 2013-01-10 2908 netif_reset_xps_queues_gt(dev, txq);
024e9679a2daaa Alexander Duyck 2013-01-10 2909 #endif
024e9679a2daaa Alexander Duyck 2013-01-10 2910 }
ac5b70198adc25 Jakub Kicinski 2018-02-12 2911 } else {
ac5b70198adc25 Jakub Kicinski 2018-02-12 2912 dev->real_num_tx_queues = txq;
f0796d5c73e597 John Fastabend 2010-07-01 2913 }
e6484930d7c73d Tom Herbert 2010-10-18 2914
e6484930d7c73d Tom Herbert 2010-10-18 2915 return 0;
f0796d5c73e597 John Fastabend 2010-07-01 2916 }
f0796d5c73e597 John Fastabend 2010-07-01 2917 EXPORT_SYMBOL(netif_set_real_num_tx_queues);
56079431b6ba16 Denis Vlasenko 2006-03-29 2918
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (134377 bytes)
Powered by blists - more mailing lists