netdev - Re: [PATCHv4 net-next 1/4] rtnetlink: add new helper rtnl_configure_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2022 17:22:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Ido Schimmel <idosch@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        Florent Fourcot <florent.fourcot@...irst.fr>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Guillaume Nault <gnault@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCHv4 net-next 1/4] rtnetlink: add new helper
 rtnl_configure_link_notify()

Hi Hangbin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Hangbin-Liu/rtnetlink-Honour-NLM_F_ECHO-flag-in-rtnl_-new-del-link/20220930-150212
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d742ea6b8e85f7b0d484bc23392d607b50667da6
config: arc-defconfig
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8c506221bc21828fb8773e553194a3bf9e607e96
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hangbin-Liu/rtnetlink-Honour-NLM_F_ECHO-flag-in-rtnl_-new-del-link/20220930-150212
        git checkout 8c506221bc21828fb8773e553194a3bf9e607e96
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash net/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/core/rtnetlink.c:3183:5: warning: no previous prototype for 'rtnl_configure_link_notify' [-Wmissing-prototypes]
    3183 | int rtnl_configure_link_notify(struct net_device *dev, const struct ifinfomsg *ifm,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/rtnl_configure_link_notify +3183 net/core/rtnetlink.c

  3182	
> 3183	int rtnl_configure_link_notify(struct net_device *dev, const struct ifinfomsg *ifm,
  3184				       struct nlmsghdr *nlh, u32 pid)
  3185	{
  3186		unsigned int old_flags;
  3187		int err;
  3188	
  3189		old_flags = dev->flags;
  3190		if (ifm && (ifm->ifi_flags || ifm->ifi_change)) {
  3191			err = __dev_change_flags(dev, rtnl_dev_combine_flags(dev, ifm),
  3192						 NULL);
  3193			if (err < 0)
  3194				return err;
  3195		}
  3196	
  3197		if (dev->rtnl_link_state == RTNL_LINK_INITIALIZED) {
  3198			__dev_notify_flags(dev, old_flags, (old_flags ^ dev->flags), pid, nlh);
  3199		} else {
  3200			dev->rtnl_link_state = RTNL_LINK_INITIALIZED;
  3201			__dev_notify_flags(dev, old_flags, ~0U, pid, nlh);
  3202		}
  3203		return 0;
  3204	}
  3205	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (38839 bytes)