lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Oct 2022 17:53:53 +0200 From: Michał Grzelak <mig@...ihalf.com> To: krzysztof.kozlowski@...aro.org Cc: davem@...emloft.net, devicetree@...r.kernel.org, edumazet@...gle.com, krzysztof.kozlowski+dt@...aro.org, kuba@...nel.org, linux-kernel@...r.kernel.org, linux@...linux.org.uk, mig@...ihalf.com, mw@...ihalf.com, netdev@...r.kernel.org, pabeni@...hat.com, robh+dt@...nel.org, upstream@...ihalf.com Subject: Re: [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema Hi Krzysztof, Thanks for your comments and time spent on reviewing my patch. All of those improvements will be included in next version. Also, I would like to know your opinion about one. >> + >> + marvell,system-controller: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: a phandle to the system controller. >> + >> +patternProperties: >> + '^eth[0-9a-f]*(@.*)?$': > > The name should be "(ethernet-)?port", unless anything depends on > particular naming? What do you think about pattern "^(ethernet-)?eth[0-9a-f]+(@.*)?$"? It resembles pattern found in net/ethernet-phy.yaml like properties:$nodename:pattern:"^ethernet-phy(@[a-f0-9]+)?$", while still passing `dt_binding_check' and `dtbs_check'. It should also comply with your comment. Best regards, Michał
Powered by blists - more mailing lists