netdev - Re: [PATCH net-next] eth: octeon: fix build after netif_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 2 Oct 2022 15:54:01 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, liuhangbin@...il.com, mkl@...gutronix.de
Subject: Re: [PATCH net-next] eth: octeon: fix build after netif_napi_add()
 changes

On Sun, Oct 02, 2022 at 10:56:50AM -0700, Jakub Kicinski wrote:
> Guenter reports I missed a netif_napi_add() call
> in one of the platform-specific drivers:
> 
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c: In function 'octeon_mgmt_probe':
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:1399:9: error: too many arguments to function 'netif_napi_add'
>  1399 |         netif_napi_add(netdev, &p->napi, octeon_mgmt_napi_poll,
>       |         ^~~~~~~~~~~~~~
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Fixes: b48b89f9c189 ("net: drop the weight argument from netif_napi_add")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Tested-by: Guenter Roeck <linux@...ck-us.net>

> ---
> CC: liuhangbin@...il.com
> CC: mkl@...gutronix.de
> ---
>  drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> index 369bfd376d6f..edde0b8fa49c 100644
> --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> @@ -1396,8 +1396,8 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, netdev);
>  	p = netdev_priv(netdev);
> -	netif_napi_add(netdev, &p->napi, octeon_mgmt_napi_poll,
> -		       OCTEON_MGMT_NAPI_WEIGHT);
> +	netif_napi_add_weight(netdev, &p->napi, octeon_mgmt_napi_poll,
> +			      OCTEON_MGMT_NAPI_WEIGHT);
>  
>  	p->netdev = netdev;
>  	p->dev = &pdev->dev;
> -- 
> 2.37.3
>