netdev - Re: [RFC PATCH] dt-bindings: net: ethernet-controller: Add ptimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzrvveFVh+Qt6TzN@hoboy.vegasvil.org>
Date:   Mon, 3 Oct 2022 07:20:45 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     "Gaddam, Sarath Babu Naidu" <sarath.babu.naidu.gaddam@....com>
Cc:     Rob Herring <robh@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yangbo.lu@....com" <yangbo.lu@....com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
        "Sarangi, Anirudha" <anirudha.sarangi@....com>,
        "Katakam, Harini" <harini.katakam@....com>
Subject: Re: [RFC PATCH] dt-bindings: net: ethernet-controller: Add
 ptimer_handle

On Mon, Oct 03, 2022 at 09:29:00AM +0000, Gaddam, Sarath Babu Naidu wrote:

> PHC(PTP Hardware clock) index is a number which is used by ptp4l
> application. When a PTP device registers with a kernel, device node
> will be created in the /dev.For example, /dev/ptp0, /dev/ptp1.
> 
> When PTP and Ethernet are in the same device driver, This PHC index
> Information is internally accessible. When they are independent drivers,
> PTP DT node should be linked to ethernet node so that PTP timer
> information such as PHC index is accessible.   

Good explanation.  The handle you propose makes sense to me.
Maybe let the name spell it out clearly?

	fman0: fman@...0000 {
		ptp-hardware-clock = <&phc0>;
	}
	phc0: ptp-timer@...e000 {
		compatible = "fsl,fman-ptp-timer";
		reg = <0x0 0x1afe000 0x0 0x1000>;
	}

In any case, to me "timer" has a different connotation than "clock".

Thanks,
Richard