netdev - Re: [PATCH iproute2-next] iplink_bridge: Add no_linklocal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7251b13-dbf2-f86c-6c2a-2c037b208017@gmail.com>
Date:   Mon, 3 Oct 2022 08:40:47 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, razor@...ckwall.org,
        netdev@...io-technology.com, mlxsw@...dia.com
Subject: Re: [PATCH iproute2-next] iplink_bridge: Add no_linklocal_learn
 option support

On 10/1/22 8:35 AM, Ido Schimmel wrote:
> @@ -159,6 +160,18 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
>  			if (len < 0)
>  				return -1;
>  			addattr_l(n, 1024, IFLA_BR_GROUP_ADDR, llabuf, len);
> +		} else if (matches(*argv, "no_linklocal_learn") == 0) {

changed matches to strcmp and applied to iproute2-next


> +			__u32 no_ll_learn_bit = 1 << BR_BOOLOPT_NO_LL_LEARN;
> +			__u8 no_ll_learn;
> +
> +			NEXT_ARG();
> +			if (get_u8(&no_ll_learn, *argv, 0))
> +				invarg("invalid no_linklocal_learn", *argv);
> +			bm.optmask |= 1 << BR_BOOLOPT_NO_LL_LEARN;
> +			if (no_ll_learn)
> +				bm.optval |= no_ll_learn_bit;
> +			else
> +				bm.optval &= ~no_ll_learn_bit;
>  		} else if (matches(*argv, "fdb_flush") == 0) {
>  			addattr(n, 1024, IFLA_BR_FDB_FLUSH);
>  		} else if (matches(*argv, "vlan_default_pvid") == 0) {