netdev - Re: [PATCH v2 net-next 3/6] sfc: optional logging of TC offload errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4ee3271-7180-c408-2b04-cec8e784176c@gmail.com>
Date:   Mon, 3 Oct 2022 20:30:32 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, linux-net-drivers@....com,
        davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        habetsm.xilinx@...il.com
Subject: Re: [PATCH v2 net-next 3/6] sfc: optional logging of TC offload
 errors

On 30/09/2022 15:19, Jakub Kicinski wrote:
> On Fri, 30 Sep 2022 10:03:01 +0100 Edward Cree wrote:
>> It has one (do_trace_netlink_extack()), but sadly that won't play
>>  so well with formatted extacks since AIUI trace needs a constant
>>  string (I'm just giving it the format string in my prototype).
>> But yeah it's better than nothing.
> 
> We can add a new one which copies the data. Presumably we'd have a "set
> an extack msg which needs to be freed" helper were we could place it?
> It'd mean we cut off at a static length but good enough, I say.

Hmm, seems I was wrong about the tracepoint, the machinery already
 handles a dynamic string just fine.
I should have an RFC patch ready in a few days.

-ed